Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2615443006: Revert of Android accessibility: automatically focus links (patchset #3 id:40001 of https://coderev… (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of Android accessibility: automatically focus links (patchset #3 id:40001 of https://codereview.chromium.org/2465403003/ ) Reason for revert: Caused scrolling bug http://crbug.com/675567 BUG=657157, 675567 Original issue's description: > Android accessibility: automatically focus links > > When setting accessibility focus to a node, auto-focus it if it's a link. > This is needed for some sites that have skip links that are only visible > when focused. It might be possible to auto-focus more than just links but > this seems the safest. > > Fixing this exposed a race condition with our code to refocus the node with > accessibility focus if its location has changed - essentially when you > click on the skip link, the skip link was changing its location, causing us > to fire notifications on it because its location had changed - but that > was racing with the real change to accessibility focus from following the > skip link. > > Fix this race condition by re-focusing the node with accessibility focus > after a short delay, and canceling the delayed task if accessibility > focus changes again. > > Tested manually with two urls that exercise these code paths. > > BUG=657157 > TESTED=http://getbootstrap.com/ and http://jsfiddle.net/mev0c4dt/show/ > > Committed: https://crrev.com/fd9566093da77d9413ba61f8be1b6e03daaadf33 > Cr-Commit-Position: refs/heads/master@{#430006} TBR=dtseng@chromium.org,sgurun@chromium.org,dmazzoni@chromium.org BUG=657157 Review-Url: https://codereview.chromium.org/2609313002 Cr-Commit-Position: refs/heads/master@{#441248} (cherry picked from commit 12c8f43c72337a88c60abaa36a9b0e8adbba9453) Committed: https://chromium.googlesource.com/chromium/src/+/02219589656825cba76ea57e307c1345b52bfea5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -73 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 7 chunks +7 lines, -68 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 11 months ago (2017-01-05 00:26:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02219589656825cba76ea57e307c1345b52bfea5.

Powered by Google App Engine
This is Rietveld 408576698