Issue 261533006: Display the color at a point.

Issue 261533006: Display the color at a point. (Closed)

Created:
6 years, 7 months ago by jcgregorio

Modified:
6 years, 7 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Display the color at a point. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14494

Patch Set 3 : comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -6 lines)			Patch
M	experimental/webtry/css/webtry.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	experimental/webtry/js/webtry.js	View	1 2	4 chunks	+52 lines, -6 lines	0 comments	Download
M	experimental/webtry/templates/content.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm, with some suggested extra comments that would have helped on first read https://codereview.chromium.org/261533006/diff/20001/experimental/webtry/js/webtry.js File ...

6 years, 7 months ago (2014-04-30 21:14:19 UTC) #2

jcgregorio

https://codereview.chromium.org/261533006/diff/20001/experimental/webtry/js/webtry.js File experimental/webtry/js/webtry.js (right): https://codereview.chromium.org/261533006/diff/20001/experimental/webtry/js/webtry.js#newcode86 experimental/webtry/js/webtry.js:86: if (s.length < 2) { On 2014/04/30 21:14:19, mtklein ...

6 years, 7 months ago (2014-05-01 12:47:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/261533006/40001

6 years, 7 months ago (2014-05-01 12:47:22 UTC) #5

Message was sent while issue was closed.

Change committed as 14494

Expand Messages | Collapse Messages