Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 261533003: Populate .current when navigator.serviceWorker is accessed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index ded0fb73c1b3cbcb63c30cc7f5e555ff6933b1f8..0ddaaf1da74e358ad6789831445c42867cef462c 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -98,10 +98,6 @@ bool ServiceWorkerDispatcherHost::OnMessageReceived(
OnProviderCreated)
IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_ProviderDestroyed,
OnProviderDestroyed)
- IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_AddScriptClient,
- OnAddScriptClient)
- IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_RemoveScriptClient,
- OnRemoveScriptClient)
IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_SetVersionId,
OnSetHostedVersionId)
IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_PostMessage,
@@ -118,8 +114,10 @@ bool ServiceWorkerDispatcherHost::OnMessageReceived(
OnReportException)
IPC_MESSAGE_HANDLER(EmbeddedWorkerHostMsg_ReportConsoleMessage,
OnReportConsoleMessage)
- IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_ServiceWorkerObjectDestroyed,
- OnServiceWorkerObjectDestroyed)
+ IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_IncrementServiceWorkerRefCount,
+ OnIncrementServiceWorkerRefCount)
+ IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_DecrementServiceWorkerRefCount,
+ OnDecrementServiceWorkerRefCount)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -276,28 +274,6 @@ void ServiceWorkerDispatcherHost::OnProviderDestroyed(int provider_id) {
context_->RemoveProviderHost(render_process_id_, provider_id);
}
-void ServiceWorkerDispatcherHost::OnAddScriptClient(
- int thread_id, int provider_id) {
- if (!context_)
- return;
- ServiceWorkerProviderHost* provider_host =
- context_->GetProviderHost(render_process_id_, provider_id);
- if (!provider_host)
- return;
- provider_host->AddScriptClient(thread_id);
-}
-
-void ServiceWorkerDispatcherHost::OnRemoveScriptClient(
- int thread_id, int provider_id) {
- if (!context_)
- return;
- ServiceWorkerProviderHost* provider_host =
- context_->GetProviderHost(render_process_id_, provider_id);
- if (!provider_host)
- return;
- provider_host->RemoveScriptClient(thread_id);
-}
-
void ServiceWorkerDispatcherHost::OnSetHostedVersionId(
int provider_id, int64 version_id) {
if (!context_)
@@ -393,9 +369,26 @@ void ServiceWorkerDispatcherHost::OnReportConsoleMessage(
params.source_url);
}
-void ServiceWorkerDispatcherHost::OnServiceWorkerObjectDestroyed(
+void ServiceWorkerDispatcherHost::OnIncrementServiceWorkerRefCount(
int handle_id) {
- handles_.Remove(handle_id);
+ ServiceWorkerHandle* handle = handles_.Lookup(handle_id);
+ if (!handle) {
+ BadMessageReceived();
+ return;
+ }
+ handle->IncrementRefCount();
+}
+
+void ServiceWorkerDispatcherHost::OnDecrementServiceWorkerRefCount(
+ int handle_id) {
+ ServiceWorkerHandle* handle = handles_.Lookup(handle_id);
+ if (!handle) {
+ BadMessageReceived();
+ return;
+ }
+ handle->DecrementRefCount();
+ if (handle->HasNoRefCount())
+ handles_.Remove(handle_id);
}
void ServiceWorkerDispatcherHost::UnregistrationComplete(

Powered by Google App Engine
This is Rietveld 408576698