Resolve ready and finished promises asynchronously

third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptPromiseProperty_h
 #define ScriptPromiseProperty_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromisePropertyBase.h"
 #include "bindings/core/v8/ToV8.h"
@@ skipping 87 matching lines @@
     : ScriptPromisePropertyBase(executionContext, name), m_holder(holder) {}
 
 template <typename HolderType, typename ResolvedType, typename RejectedType>
 template <typename PassResolvedType>
 void ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::resolve(
     PassResolvedType value) {
   if (getState() != Pending) {
     NOTREACHED();
     return;
   }
+  DCHECK(!ScriptForbiddenScope::isScriptForbidden());

[esprehn, 2017/01/06 21:10:25]

We usually RELEASE_ASSERT/CHECK this instead so it doesn't let security bugs
through.

[adithyas, 2017/01/06 21:33:41]

I plan on adding a RELEASE_ASSERT in a different patch. I added the DCHECK as a
regression test, a few of the web-animation-api/ and animation/ layout tests
fail with this added in (if the promises are resolved synchronously).

Also, the execution context checks are right below this line :)

   if (!getExecutionContext() || getExecutionContext()->isContextDestroyed())
     return;
   m_resolved = value;
   resolveOrReject(Resolved);
 }
 
 template <typename HolderType, typename ResolvedType, typename RejectedType>
 void ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::
     resolveWithUndefined() {
   if (getState() != Pending) {
@@ skipping 76 matching lines @@
     VisitorDispatcher visitor) {
   TraceIfNeeded<HolderType>::trace(visitor, m_holder);
   TraceIfNeeded<ResolvedType>::trace(visitor, m_resolved);
   TraceIfNeeded<RejectedType>::trace(visitor, m_rejected);
   ScriptPromisePropertyBase::trace(visitor);
 }
 
 }  // namespace blink
 
 #endif  // ScriptPromiseProperty_h