Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2615223003: Use MemberElement instead of Element in function sets and selectors. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use MemberElement instead of Element in function sets and selectors. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/90dfdf7cf31162c68e32e9950cd18138792d4964

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +3 lines, -1 line 2 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 14 chunks +25 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-06 15:43:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2615223003/diff/1/pkg/compiler/lib/src/inferrer/closure_tracer.dart File pkg/compiler/lib/src/inferrer/closure_tracer.dart (right): https://codereview.chromium.org/2615223003/diff/1/pkg/compiler/lib/src/inferrer/closure_tracer.dart#newcode52 pkg/compiler/lib/src/inferrer/closure_tracer.dart:52: if (!selector.callStructure.signatureApplies(functionElement.functionSignature)) { dartfmt
3 years, 11 months ago (2017-01-06 20:49:43 UTC) #3
Johnni Winther
https://codereview.chromium.org/2615223003/diff/1/pkg/compiler/lib/src/inferrer/closure_tracer.dart File pkg/compiler/lib/src/inferrer/closure_tracer.dart (right): https://codereview.chromium.org/2615223003/diff/1/pkg/compiler/lib/src/inferrer/closure_tracer.dart#newcode52 pkg/compiler/lib/src/inferrer/closure_tracer.dart:52: if (!selector.callStructure.signatureApplies(functionElement.functionSignature)) { On 2017/01/06 20:49:43, Siggi Cherem (dart-lang) ...
3 years, 11 months ago (2017-01-09 09:55:11 UTC) #4
Johnni Winther
3 years, 11 months ago (2017-01-09 09:55:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
90dfdf7cf31162c68e32e9950cd18138792d4964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698