third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp - Issue 2615203002: Remove multicol special-cases from invalidation and the pre-paint tree walk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp

Issue 2615203002: Remove multicol special-cases from invalidation and the pre-paint tree walk (Closed)

Patch Set: Cleanup comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp

index cd055b618c7f4ded53f71d92cc1a3430503c8276..4ea37764cefc7d6fe9e92c633cbea3db757dbd83 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp

@@ -141,13 +141,6 @@ void LayoutMultiColumnSpannerPlaceholder::computeLogicalHeight(

computedValues.m_margins.m_after = marginAfter();

}

-void LayoutMultiColumnSpannerPlaceholder::invalidatePaintOfSubtreesIfNeeded(

- const PaintInvalidationState& childPaintInvalidationState) {

- m_layoutObjectInFlowThread->invalidateTreeIfNeeded(

- childPaintInvalidationState);

- LayoutBox::invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState);

void LayoutMultiColumnSpannerPlaceholder::paint(

const PaintInfo& paintInfo,

const LayoutPoint& paintOffset) const {