Issue 2615173002: Revert "Ensure we're looking at the correct resolved AST when initializing fields in constructors."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2615173002: Revert "Ensure we're looking at the correct resolved AST when initializing fields in constructors." (Closed)

Created:
3 years, 11 months ago by Emily Fortuna

Modified:
3 years, 11 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Ensure we're looking at the correct resolved AST when initializing fields in constructors." This reverts commit 0c78abd0900d10198216034f296204f4de1c111e. The change to in-memory tests requires a little more finesse than what is written. Backing out to redo. BUG= Committed: https://github.com/dart-lang/sdk/commit/5f60d0c3c458d559ef8d7a6cc75b712c147f7038

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -55 lines)			Patch
M	pkg/compiler/lib/src/resolved_uri_translator.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/graph_builder.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View	4 chunks	+1 line, -22 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/constructors_test.dart	View	1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Emily Fortuna

3 years, 11 months ago (2017-01-06 01:53:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5f60d0c3c458d559ef8d7a6cc75b712c147f7038 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages