Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: remoting/host/host_experiment_servant.h

Issue 2615113005: [Chromoting] Use HostExperimentSessionPlugin in host (Closed)
Patch Set: Resolve review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/host_experiment_servant.h
diff --git a/remoting/host/host_experiment_session_plugin.h b/remoting/host/host_experiment_servant.h
similarity index 80%
rename from remoting/host/host_experiment_session_plugin.h
rename to remoting/host/host_experiment_servant.h
index 20627420f40812bbc1747bee3946103744c7db46..b2e9e5d3637844cf1e654f98bbd8a8e4059fb993 100644
--- a/remoting/host/host_experiment_session_plugin.h
+++ b/remoting/host/host_experiment_servant.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef REMOTING_HOST_HOST_EXPERIMENT_SESSION_PLUGIN_H_
-#define REMOTING_HOST_HOST_EXPERIMENT_SESSION_PLUGIN_H_
+#ifndef REMOTING_HOST_HOST_EXPERIMENT_SERVANT_H_
+#define REMOTING_HOST_HOST_EXPERIMENT_SERVANT_H_
#include <memory>
#include <string>
@@ -15,7 +15,7 @@ namespace remoting {
// A SessionPlugin implementation to send host attributes to client, and
// receives experiment settings.
-class HostExperimentSessionPlugin : public protocol::SessionPlugin {
+class HostExperimentServant : public protocol::SessionPlugin {
Sergey Ulanov 2017/01/09 23:00:26 I don't think it's necessary to rename this class
Hzj_jie 2017/01/10 02:31:09 No, HostExperimentServer is definitely not correct
joedow 2017/01/10 15:11:47 Drive-by comment. 'Servant' is not standard nomen
public:
using SessionPlugin::SessionPlugin;
@@ -38,4 +38,4 @@ class HostExperimentSessionPlugin : public protocol::SessionPlugin {
} // namespace remoting
-#endif // REMOTING_HOST_HOST_EXPERIMENT_SESSION_PLUGIN_H_
+#endif // REMOTING_HOST_HOST_EXPERIMENT_SERVANT_H_

Powered by Google App Engine
This is Rietveld 408576698