[Chromoting] Use HostExperimentSessionPlugin in host

remoting/protocol/protocol_mock_objects.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_PROTOCOL_MOCK_OBJECTS_H_
 #define REMOTING_PROTOCOL_PROTOCOL_MOCK_OBJECTS_H_
 
 #include <cstdint>
+#include <deque>
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/values.h"
 #include "net/base/ip_endpoint.h"
 #include "remoting/proto/internal.pb.h"
 #include "remoting/proto/video.pb.h"
 #include "remoting/protocol/authenticator.h"
 #include "remoting/protocol/channel_authenticator.h"
 #include "remoting/protocol/client_stub.h"
 #include "remoting/protocol/clipboard_stub.h"
 #include "remoting/protocol/connection_to_client.h"
 #include "remoting/protocol/host_stub.h"
 #include "remoting/protocol/input_stub.h"
+#include "remoting/protocol/jingle_messages.h"
 #include "remoting/protocol/pairing_registry.h"
 #include "remoting/protocol/session.h"
 #include "remoting/protocol/session_manager.h"
 #include "remoting/protocol/transport.h"
 #include "remoting/protocol/video_stub.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "third_party/libjingle_xmpp/xmllite/xmlelement.h"
 
 namespace remoting {
 
@@ skipping 158 matching lines @@
  public:
   MockSession();
   ~MockSession() override;
 
   MOCK_METHOD1(SetEventHandler, void(Session::EventHandler* event_handler));
   MOCK_METHOD0(error, ErrorCode());
   MOCK_METHOD1(SetTransport, void(Transport*));
   MOCK_METHOD0(jid, const std::string&());
   MOCK_METHOD0(config, const SessionConfig&());
   MOCK_METHOD1(Close, void(ErrorCode error));
-  MOCK_METHOD1(AddPlugin, void(SessionPlugin* plugin));
+
+  // Sends |attachments_| to the |plugin|->OnIncomingMessage().
+  void AddPlugin(SessionPlugin* plugin) override;
+
+  // Adds an |attachment| to |round|, which will be sent to plugins added by
+  // AddPlugin() function.
+  void SetAttachment(size_t round,

[Sergey Ulanov, 2017/01/07 01:23:09]

It's better to avoid mixing non-GMock code into Mock classes. I suggest updating
client_session_unittest.cc to use FakeSession instead of MockSession and
implement this feature in FakeSession.

I think we should get rid of MockSession and use FakeSession everywhere (not in
this CL obviously). That would make tests cleaner.
Beside client_session_unittest.cc MockSession is used only in
chromoting_host_unittest.cc.

[Hzj_jie, 2017/01/08 23:48:49]

Done.

+                     std::unique_ptr<buzz::XmlElement> attachment);
 
  private:
+  std::deque<JingleMessage> attachments_;
   DISALLOW_COPY_AND_ASSIGN(MockSession);
 };
 
 class MockSessionManager : public SessionManager {
  public:
   MockSessionManager();
   ~MockSessionManager() override;
 
   MOCK_METHOD1(AcceptIncoming, void(const IncomingSessionCallback&));
   void set_protocol_config(
@@ skipping 47 matching lines @@
   // Runs tasks synchronously instead of posting them to |task_runner|.
   void PostTask(const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
                 const tracked_objects::Location& from_here,
                 const base::Closure& task) override;
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_PROTOCOL_MOCK_OBJECTS_H_