[Chromoting] Use HostExperimentSessionPlugin in host

remoting/host/client_session_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/client_session.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <string>
 #include <utility>
 #include <vector>
 
+#include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "build/build_config.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/base/constants.h"
 #include "remoting/codec/video_encoder_verbatim.h"
 #include "remoting/host/desktop_environment.h"
 #include "remoting/host/fake_desktop_environment.h"
@@ skipping 70 matching lines @@
 
 }  // namespace
 
 class ClientSessionTest : public testing::Test {
  public:
   ClientSessionTest() : client_jid_("user@domain/rest-of-jid") {}
 
   void SetUp() override;
   void TearDown() override;
 
+ protected:
+  // Creates the client session from a MockSession instance.
+  void CreateClientSession(std::unique_ptr<protocol::MockSession> session);
+
   // Creates the client session.
   void CreateClientSession();
 
- protected:
   // Notifies the client session that the client connection has been
   // authenticated and channels have been connected. This effectively enables
   // the input pipe line and starts video capturing.
   void ConnectClientSession();
 
   // Fakes video size notification from the VideoStream.
   void NotifyVideoSize();
 
-  // Creates expectations to send an extension message and to disconnect
-  // afterwards.
-  void SetSendMessageAndDisconnectExpectation(const std::string& message_type);
-
   // Message loop that will process all ClientSession tasks.
   base::MessageLoop message_loop_;
 
   // AutoThreadTaskRunner on which |client_session_| will be run.
   scoped_refptr<AutoThreadTaskRunner> task_runner_;
 
   // Used to run |message_loop_| after each test, until no objects remain that
   // require it.
   base::RunLoop run_loop_;
 
@@ skipping 36 matching lines @@
     client_session_.reset();
     desktop_environment_factory_.reset();
   }
 
   // Clear out |task_runner_| reference so the loop can quit, and run it until
   // it does.
   task_runner_ = nullptr;
   run_loop_.Run();
 }
 
-void ClientSessionTest::CreateClientSession() {
+void ClientSessionTest::CreateClientSession(
+    std::unique_ptr<protocol::MockSession> session) {
+  DCHECK(session);
   // Mock protocol::Session APIs called directly by ClientSession.
-  std::unique_ptr<protocol::MockSession> session(new MockSession());
   EXPECT_CALL(*session, config()).WillRepeatedly(ReturnRef(*session_config_));
   EXPECT_CALL(*session, jid()).WillRepeatedly(ReturnRef(client_jid_));
 
   // Mock protocol::ConnectionToClient APIs called directly by ClientSession.
   // HostStub is not touched by ClientSession, so we can safely pass nullptr.
   std::unique_ptr<protocol::FakeConnectionToClient> connection(
       new protocol::FakeConnectionToClient(std::move(session)));
   connection->set_client_stub(&client_stub_);
   connection_ = connection.get();
 
   client_session_.reset(
       new ClientSession(&session_event_handler_, std::move(connection),
                         desktop_environment_factory_.get(),
                         DesktopEnvironmentOptions::CreateDefault(),
                         base::TimeDelta(), nullptr, extensions_));
 }
 
+void ClientSessionTest::CreateClientSession() {
+  CreateClientSession(base::MakeUnique<protocol::MockSession>());
+}
+
 void ClientSessionTest::ConnectClientSession() {
   EXPECT_CALL(session_event_handler_, OnSessionAuthenticated(_));
   EXPECT_CALL(session_event_handler_, OnSessionChannelsConnected(_));
 
   // Stubs should be set only after connection is authenticated.
   EXPECT_FALSE(connection_->clipboard_stub());
   EXPECT_FALSE(connection_->input_stub());
 
   client_session_->OnConnectionAuthenticated();
 
@@ skipping 218 matching lines @@
   EXPECT_TRUE(extension1.has_handled_message());
 
   // ext2 was instantiated but not sent a message, and wrapped video encoder.
   EXPECT_TRUE(extension2.was_instantiated());
   EXPECT_FALSE(extension2.has_handled_message());
 
   // ext3 was sent a message but not instantiated.
   EXPECT_FALSE(extension3.was_instantiated());
 }
 
+#if defined(OS_WIN)
+TEST_F(ClientSessionTest, ForwardHostSessionOptions) {
+  std::unique_ptr<protocol::MockSession> session(new protocol::MockSession());

[Sergey Ulanov, 2017/01/07 01:23:09]

nit: This line may would be more readable if written as follows:
 auto session = base::MakeUnique<protocol::MockSession>();

Same for the line below.

[Hzj_jie, 2017/01/08 23:48:48]

Done.

+  std::unique_ptr<buzz::XmlElement> configuration(new buzz::XmlElement(
+      buzz::QName(kChromotingXmlNamespace, "host-configuration")));
+  configuration->SetBodyText("Allow-DirectX-Capturer:");
+  session->SetAttachment(0, std::move(configuration));
+  CreateClientSession(std::move(session));
+  ConnectClientSession();
+  ASSERT_TRUE(desktop_environment_factory_->last_desktop_environment()
+      ->options().desktop_capture_options()->allow_directx_capturer());

[Sergey Ulanov, 2017/01/07 01:23:09]

'git cl format' please

[Hzj_jie, 2017/01/08 23:48:48]

Done.

+}
+#endif
+
 }  // namespace remoting