Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/barback/lib/src/utils.dart

Issue 26151002: Rename runAsync to scheduleMicrotask. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix 80 chars lines Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/custom_element/lib/custom_element.dart » ('j') | pkg/mdv/lib/src/input_bindings.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/utils.dart
diff --git a/pkg/barback/lib/src/utils.dart b/pkg/barback/lib/src/utils.dart
index 33cf145bdae68651ceb8747999ed2b1b6365a3eb..a720f458e3b3d73cb36ae79dcf1f84a17203c778 100644
--- a/pkg/barback/lib/src/utils.dart
+++ b/pkg/barback/lib/src/utils.dart
@@ -168,10 +168,10 @@ String prefixLines(String text, {String prefix: '| ', String firstPrefix}) {
/// any code to run, as long as it's not waiting on some external event.
Future pumpEventQueue([int times=20]) {
if (times == 0) return new Future.value();
- // We use a delayed future to allow runAsync events to finish. The
- // Future.value or Future() constructors use runAsync themselves and would
- // therefore not wait for runAsync callbacks that are scheduled after invoking
- // this method.
+ // We use a delayed future to allow microtask events to finish. The
+ // Future.value or Future() constructors use scheduleMicrotask themselves and
Lasse Reichstein Nielsen 2013/10/07 07:17:03 `scheduleMicrotask` or [scheduleMicrotask]
floitsch 2013/10/10 16:00:36 In normal comments it's ok.
+ // would therefore not wait for microtask callbacks that are scheduled after
+ // invoking this method.
return new Future.delayed(Duration.ZERO, () => pumpEventQueue(times - 1));
}
« no previous file with comments | « no previous file | pkg/custom_element/lib/custom_element.dart » ('j') | pkg/mdv/lib/src/input_bindings.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698