Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4291)

Unified Diff: chrome/browser/resources/settings/controls/controlled_button.html

Issue 2615093003: MD Settings: add <controlled-button>#endJustified to flip controlled by indicator position (Closed)
Patch Set: didn't need text-align end after all Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/controlled_button.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/controlled_button.html
diff --git a/chrome/browser/resources/settings/controls/controlled_button.html b/chrome/browser/resources/settings/controls/controlled_button.html
index 9868ce04efb72caf2cab394fa1bdc87ecdad5c92..57d6a562f2b816b2749a8f2e19bcea045f56cb9a 100644
--- a/chrome/browser/resources/settings/controls/controlled_button.html
+++ b/chrome/browser/resources/settings/controls/controlled_button.html
@@ -12,6 +12,7 @@
:host {
align-items: center;
display: flex;
+ --justify-margin: 18px;
}
:host([controlled_]) {
@@ -21,11 +22,19 @@
}
cr-policy-pref-indicator {
- -webkit-margin-start: var(--checkbox-spacing);
/* Enable pointer events for the indicator so :hover works. Disable
* clicks/taps via onIndicatorTap_ so outer on-tap doesn't trigger. */
pointer-events: all;
}
+
+ :host(:not([end-justified])) cr-policy-pref-indicator {
+ -webkit-margin-start: var(--justify-margin);
+ }
+
+ :host([end-justified]) cr-policy-pref-indicator {
+ -webkit-margin-end: var(--justify-margin);
+ order: -1;
dschuyler 2017/01/07 02:12:20 I'm not familiar with order: -1 to be sure it's co
Dan Beam 2017/01/07 02:14:18 trust me, it's magical
+ }
</style>
<paper-button disabled="[[controlled_]]">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/controlled_button.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698