Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Unified Diff: chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc

Issue 2615013002: gzip VR Shell's UI resources (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc
diff --git a/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc b/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc
index 5e615ea2b36be0db7b3c30c50933cf61f3086da3..851abbe48d181a1b7f1f65c93be4e36e005cfd63 100644
--- a/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc
+++ b/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc
@@ -183,15 +183,13 @@ void RemoteDataSource::OnURLFetchComplete(const net::URLFetcher* source) {
content::WebUIDataSource* CreateVrShellUIHTMLSource() {
content::WebUIDataSource* source =
content::WebUIDataSource::Create(chrome::kChromeUIVrShellUIHost);
+ std::unordered_set<std::string> excluded_paths;
+ source->UseGzip(excluded_paths);
Dan Beam 2017/01/05 17:22:17 source->UseGzip(std::unordered_set<std::string>())
mthiesse 2017/01/05 17:25:37 Done.
source->AddResourcePath("vr_shell_ui.css", IDR_VR_SHELL_UI_CSS);
source->AddResourcePath("vr_shell_ui.js", IDR_VR_SHELL_UI_JS);
source->AddResourcePath("vr_shell_ui_api.js", IDR_VR_SHELL_UI_API_JS);
source->AddResourcePath("vr_shell_ui_scene.js", IDR_VR_SHELL_UI_SCENE_JS);
source->SetDefaultResource(IDR_VR_SHELL_UI_HTML);
- // We're localizing strings, so we can't currently use gzip since it's
- // incompatible with i18n. TODO(klausw): re-enable gzip once an i18n
- // compatible variant of WebUIDataSource's UseGzip gets added, and add
- // compress=gzip to browser_resources.grd as appropriate.
source->AddLocalizedString(
"insecureWebVrContentPermanent",
IDS_WEBSITE_SETTINGS_INSECURE_WEBVR_CONTENT_PERMANENT);
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698