Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2615003002: Use ChromeBrowserStateManager instead of BrowserListIOS. (Closed)
Patch Set: Fix ios_chrome_perftests. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/chrome/browser/test/perf_test_with_bvc_ios.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index 9ae72de45bb161ad26be9f6c2a9fad297d254ec1..0b10e803e01f76258024cd172edd25bbfa96aa27 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -7,6 +7,7 @@
#include <memory>
#include "base/callback.h"
+#include "base/files/file_path.h"
#include "base/ios/block_types.h"
#include "base/mac/scoped_nsobject.h"
#include "base/memory/ptr_util.h"
@@ -19,6 +20,7 @@
#include "components/keyed_service/core/service_access_type.h"
#include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
+#include "ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h"
#import "ios/chrome/browser/chrome_url_util.h"
#include "ios/chrome/browser/history/history_service_factory.h"
#import "ios/chrome/browser/tabs/tab.h"
@@ -29,6 +31,7 @@
#import "ios/chrome/browser/web/external_app_launcher.h"
#include "ios/chrome/test/block_cleanup_test.h"
#include "ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.h"
+#include "ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_state_manager.h"
#include "ios/chrome/test/ios_chrome_scoped_testing_local_state.h"
#import "ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_metadata.h"
#import "ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.h"
@@ -160,7 +163,11 @@ class FakeChromeBrowserProvider : public ios::TestChromeBrowserProvider {
class TabTest : public BlockCleanupTest {
public:
- TabTest() : thread_bundle_(web::TestWebThreadBundle::REAL_FILE_THREAD) {}
+ TabTest()
+ : thread_bundle_(web::TestWebThreadBundle::REAL_FILE_THREAD),
+ scoped_browser_state_manager_(
+ base::MakeUnique<TestChromeBrowserStateManager>(base::FilePath())) {
+ }
void SetUp() override {
BlockCleanupTest::SetUp();
@@ -310,7 +317,7 @@ class TabTest : public BlockCleanupTest {
protected:
web::TestWebThreadBundle thread_bundle_;
- IOSChromeScopedTestingLocalState local_state_;
+ IOSChromeScopedTestingChromeBrowserStateManager scoped_browser_state_manager_;
std::unique_ptr<TestChromeBrowserState> chrome_browser_state_;
base::scoped_nsobject<Tab> tab_;
history::HistoryService* history_service_; // weak
@@ -549,10 +556,4 @@ TEST_F(TabOpenAppOffTheRecordTest, DISABLED_testResetShouldAutoOpenOnFailure) {
EXPECT_FALSE([metadata shouldAutoOpenLinks]);
}
-class TestRequestGroupID : public BlockCleanupTest {
- public:
- void SetUp() override { BlockCleanupTest::SetUp(); }
- void TearDown() override { BlockCleanupTest::TearDown(); }
-};
-
} // namespace
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/chrome/browser/test/perf_test_with_bvc_ios.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698