Issue 2614983004: Reapply 0c78abd0900d

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2614983004: Reapply 0c78abd0900d (Closed)

Created:
3 years, 11 months ago by Emily Fortuna

Modified:
3 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Reapply 0c78abd0900d "Ensure we're looking at the correct resolved AST when initializing fields in constructors." BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/745c2989f415bf4d712c674760d44b4de82eb86f

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -9 lines)			Patch
M	pkg/compiler/lib/src/resolved_uri_translator.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View		5 chunks	+10 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View		3 chunks	+19 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/categories_test.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/constructors_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Emily Fortuna

Take two of that CL. Basically another test was an "in-memory" test and it imported ...

3 years, 11 months ago (2017-01-06 18:58:53 UTC) #2

Emily Fortuna

3 years, 11 months ago (2017-01-06 19:01:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
745c2989f415bf4d712c674760d44b4de82eb86f (presubmit successful).