third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp - Issue 2614883007: Change computed style enums to be prefixed with 'k'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)

Patch Set: Rebase on ToT. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

index 8f7fb6dd3cb59ccfe776d2701fd2a0740f8b50bd..54cb2e98b86e919216404e4b16aa89dead88440d 100644

--- a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

@@ -30,8 +30,8 @@ class CSSVisibilityNonInterpolableValue : public NonInterpolableValue {

return m_start;

if (fraction >= 1)

return m_end;

- if (m_start == EVisibility::Visible || m_end == EVisibility::Visible)

- return EVisibility::Visible;

+ if (m_start == EVisibility::kVisible || m_end == EVisibility::kVisible)

+ return EVisibility::kVisible;

return fraction < 0.5 ? m_start : m_end;

}

@@ -118,7 +118,7 @@ InterpolationValue CSSVisibilityInterpolationType::maybeConvertNeutral(

InterpolationValue CSSVisibilityInterpolationType::maybeConvertInitial(

const StyleResolverState&,

ConversionCheckers&) const {

- return createVisibilityValue(EVisibility::Visible);

+ return createVisibilityValue(EVisibility::kVisible);

}

InterpolationValue CSSVisibilityInterpolationType::maybeConvertInherit(