third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp - Issue 2614883007: Change computed style enums to be prefixed with 'k'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)

Patch Set: Rebase on ToT. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

index 493dd507048b17620c81c4878e86a1afdd4c77db..7e249d24dbb6133f5fab098aab0da7671f9a2934 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

@@ -147,14 +147,14 @@ void PrintTo(const AnimatableUnknown& animUnknown, ::std::ostream* os) {

void PrintTo(const AnimatableVisibility& animVisibility, ::std::ostream* os) {

*os << "AnimatableVisibility(";

switch (animVisibility.visibility()) {

- case EVisibility::Visible:

- *os << "EVisibility::Visible";

+ case EVisibility::kVisible:

+ *os << "EVisibility::kVisible";

break;

- case EVisibility::Hidden:

- *os << "EVisibility::Hidden";

+ case EVisibility::kHidden:

+ *os << "EVisibility::kHidden";

break;

- case EVisibility::Collapse:

- *os << "EVisibility::Collapse";

+ case EVisibility::kCollapse:

+ *os << "EVisibility::kCollapse";

Łukasz Anforowicz 2017/01/06 17:28:07 AFAICT the changes in this file are the only place

break;

default:

*os << "Unknown Visibility - update switch in "