Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2614883005: CSS Transitions: Fix flaky move-after-transition.html (Closed)

Created:
3 years, 11 months ago by Eric Willigers
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, mac-reviews_chromium.org, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Transitions: Fix flaky move-after-transition.html We force a style recalc at the start, so a transition occurs. We wait for the compositor before declaring the test complete. BUG=248938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -89 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/transitions/move-after-transition-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/transitions/move-after-transition-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/transitions/move-after-transition-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/transitions/move-after-transition-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/transitions/move-after-transition-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/transitions/move-after-transition-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/transitions/move-after-transition-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/transitions/move-after-transition-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/transitions/move-after-transition-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/transitions/move-after-transition-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/move-after-transition.html View 3 chunks +15 lines, -13 lines 0 comments Download
A third_party/WebKit/LayoutTests/transitions/move-after-transition-expected.html View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eric Willigers
3 years, 11 months ago (2017-01-06 03:51:39 UTC) #6
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 11 months ago (2017-01-06 03:56:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614883005/1
3 years, 11 months ago (2017-01-06 03:57:30 UTC) #9
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-06 04:05:26 UTC) #12
Eric Willigers
3 years, 11 months ago (2017-01-06 04:15:42 UTC) #13
On 2017/01/06 04:05:26, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Cr-Commit-Position: refs/heads/master@{#441867}

Powered by Google App Engine
This is Rietveld 408576698