third_party/WebKit/LayoutTests/vr/getVRDisplays_native_impl.html - Issue 2614873002: Ensure navigator.getVRDisplays always resolves.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/vr/getVRDisplays_native_impl.html

Issue 2614873002: Ensure navigator.getVRDisplays always resolves. (Closed)

Patch Set: Removed some unneeded includes in test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	ddorwin 2017/01/05 20:33:02 Regarding the file name: It seems that mocking sh Regarding the file name: It seems that mocking should be the exception. I realize that's not the case now. Also, this seems like a good WPT so the naming should be generic. It would be nice if the name provided more information too. For example, getVRDisplays_always_resolves. Why do the vr/ test filenames have underscores and mixed case? All/most other tests seem to use dashes and all lowercase letters.
	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5

	6 promise_test(t => navigator.getVRDisplays().then(devices => {

	7 assert_true(devices != null);
	ddorwin 2017/01/05 20:33:02 Can we check the type? Can we check the type?
	8 assert_greater_than_equal(0, devices.length);

	9 }), "Test that getVRDisplays always resolves to at least an empty array.");
	ddorwin 2017/01/05 20:33:02 s/to/with/ ? s/array/sequence/ s/to/with/ ? s/array/sequence/
	10

	11 </script>

OLD	NEW