[Devtools] Network group experiment is now grouped by connectionId

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index bff7d1641d83bc72a1b777679da7abdea7a808dd..5efa2a60ac680426089434127b01d11e0caa8de0 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -791,15 +791,13 @@ Network.NetworkLogView = class extends UI.VBox {
       var isFilteredOut = !this._applyFilter(node);
       if (isFilteredOut && node === this._hoveredNode)
         this._setHoveredNode(null);
-      if (node[Network.NetworkLogView._isFilteredOutSymbol] !== isFilteredOut) {

[dgozman, 2017/01/10 00:50:28]

Why change this?

[allada, 2017/01/19 01:31:31]

Because the parent may now change and we need to remove the item from the
current parent then add it back.

-        if (!node[Network.NetworkLogView._isFilteredOutSymbol])
-          node.parent.removeChild(node);
 
-        node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
+      if (node.parent)
+        node.parent.removeChild(node);
+      node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
+      if (!node[Network.NetworkLogView._isFilteredOutSymbol])
+        nodesToInsert.push(node);
 
-        if (!node[Network.NetworkLogView._isFilteredOutSymbol])
-          nodesToInsert.push(node);
-      }
       if (!isFilteredOut)
         nodesToRefresh.push(node);
       var request = node.request();
@@ -837,11 +835,11 @@ Network.NetworkLogView = class extends UI.VBox {
 
     var request = node.request();
     // TODO(allada) Make this dynamic and allow multiple grouping types.
-    var groupKey = request.domain;
+    var groupKey = request.connectionId;
     var group = this._nodeGroups.get(groupKey);
     if (group)
       return group;
-    group = new Network.NetworkGroupNode(this, groupKey);
+    group = new Network.NetworkGroupNode(this, request.url.asParsedURL().host + ' - ' + groupKey);

[dgozman, 2017/01/10 00:50:28]

Don't forget to rebase and use .url() method.

[allada, 2017/01/19 01:31:31]

Done.

     this._nodeGroups.set(groupKey, group);
     this._dataGrid.rootNode().appendChild(group);
     return group;