[Devtools] Network group experiment is now grouped by connectionId

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 773 matching lines @@
     var nodesToInsert = [];
     /** @type {!Array<!Network.NetworkRequestNode> } */
     var nodesToRefresh = [];
     for (var requestId in this._staleRequestIds) {
       var node = this._nodesByRequestId.get(requestId);
       if (!node)
         continue;
       var isFilteredOut = !this._applyFilter(node);
       if (isFilteredOut && node === this._hoveredNode)
         this._setHoveredNode(null);
-      if (node[Network.NetworkLogView._isFilteredOutSymbol] !== isFilteredOut) {

[dgozman, 2017/01/10 00:50:28]

Why change this?

[allada, 2017/01/19 01:31:31]

Because the parent may now change and we need to remove the item from the
current parent then add it back.

-        if (!node[Network.NetworkLogView._isFilteredOutSymbol])
-          node.parent.removeChild(node);
 
-        node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
+      if (node.parent)
+        node.parent.removeChild(node);
+      node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
+      if (!node[Network.NetworkLogView._isFilteredOutSymbol])
+        nodesToInsert.push(node);
 
-        if (!node[Network.NetworkLogView._isFilteredOutSymbol])
-          nodesToInsert.push(node);
-      }
       if (!isFilteredOut)
         nodesToRefresh.push(node);
       var request = node.request();
       this._timeCalculator.updateBoundaries(request);
       this._durationCalculator.updateBoundaries(request);
     }
 
     for (var i = 0; i < nodesToInsert.length; ++i) {
       var node = nodesToInsert[i];
       var request = node.request();
@@ skipping 17 matching lines @@
   /**
    * @param {!Network.NetworkRequestNode} node
    * @return {!Network.NetworkNode}
    */
   _parentNodeForInsert(node) {
     if (!Runtime.experiments.isEnabled('networkGroupingRequests'))
       return /** @type {!Network.NetworkNode} */ (this._dataGrid.rootNode());
 
     var request = node.request();
     // TODO(allada) Make this dynamic and allow multiple grouping types.
-    var groupKey = request.domain;
+    var groupKey = request.connectionId;
     var group = this._nodeGroups.get(groupKey);
     if (group)
       return group;
-    group = new Network.NetworkGroupNode(this, groupKey);
+    group = new Network.NetworkGroupNode(this, request.url.asParsedURL().host + ' - ' + groupKey);

[dgozman, 2017/01/10 00:50:28]

Don't forget to rebase and use .url() method.

[allada, 2017/01/19 01:31:31]

Done.

     this._nodeGroups.set(groupKey, group);
     this._dataGrid.rootNode().appendChild(group);
     return group;
   }
 
   reset() {
     this._requestWithHighlightedInitiators = null;
     this.dispatchEventToListeners(Network.NetworkLogView.Events.RequestSelected, null);
 
     this._clearSearchMatchedList();
@@ skipping 863 matching lines @@
   Running: 'running',
   FromCache: 'from-cache'
 };
 
 /** @type {!Array<string>} */
 Network.NetworkLogView._searchKeys =
     Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLogView.FilterType[key]);
 
 /** @typedef {function(!SDK.NetworkRequest): boolean} */
 Network.NetworkLogView.Filter;