Fix a crash of SRI when used with web workers

Fix a crash of SRI when used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org

[yhirano, 2017-01-05 08:12:17]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 08:12:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-05 08:14:52]

Description was changed from

==========
Fix a crash of SRI is used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=mkwst@chromium.org
==========

to

==========
Fix a crash of SRI when used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org
==========

[yhirano, 2017-01-05 08:14:52]

yhirano@chromium.org changed reviewers:
+ jochen@chromium.org
- mkwst@chromium.org

[yhirano, 2017-01-05 08:15:45]

Description was changed from

==========
Fix a crash of SRI when used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org
==========

to

==========
Fix a crash of SRI when used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org
TEST=https://w3c-test.org/fetch/api/basic/integrity-worker.html
==========

[commit-bot: I haz the power, 2017-01-05 09:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 09:50:38]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-05 16:04:14]

can you please add a test?

https://codereview.chromium.org/2614813004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp (right):

https://codereview.chromium.org/2614813004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp:8: #include
"core/dom/Document.h"
do we still need this include now?

[yhirano, 2017-01-06 09:27:59]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2017-01-06 09:28:01]

Description was changed from

==========
Fix a crash of SRI when used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org
TEST=https://w3c-test.org/fetch/api/basic/integrity-worker.html
==========

to

==========
Fix a crash of SRI when used with web workers

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org
==========

[yhirano, 2017-01-06 09:28:59]

Added a layout test.

https://codereview.chromium.org/2614813004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp (right):

https://codereview.chromium.org/2614813004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp:8: #include
"core/dom/Document.h"
On 2017/01/05 16:04:14, jochen wrote:
> do we still need this include now?

We are upcasting from Document to ExecutionContext. For the inheritance
information we need the header.

[commit-bot: I haz the power, 2017-01-06 09:30:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 11:16:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 11:16:36]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-09 08:39:38]

lgtm

[yhirano, 2017-01-11 02:00:31]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:31:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484100031715020,
"parent_rev": "b554c05ac115a02e49b478fb737604719b479efb", "commit_rev":
"65f4db51ec74c23432addc7b43a7bb0554c75157"}

[commit-bot: I haz the power, 2017-01-11 04:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:38:04]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[yhirano, 2017-01-11 04:39:43]

It's landed. Closing...

[yhirano, 2017-01-11 04:40:40]

On 2017/01/11 04:39:43, yhirano wrote:
> It's landed. Closing...

https://chromium.googlesource.com/chromium/src/+/65f4db51ec74c23432addc7b43a7...