Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5481)

Unified Diff: chrome/test/data/webui/md_bookmarks/store_test.js

Issue 2614703003: [MD Bookmarks] Add search. (Closed)
Patch Set: Add search result refresh for bookmark editing. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/toolbar.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/md_bookmarks/store_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/store_test.js b/chrome/test/data/webui/md_bookmarks/store_test.js
index ebc15638053f0eb4783659e0c7e4bb285f248544..a1cf7e0e42cf12e54260a79b23a8a7a35bce2eaf 100644
--- a/chrome/test/data/webui/md_bookmarks/store_test.js
+++ b/chrome/test/data/webui/md_bookmarks/store_test.js
@@ -32,19 +32,21 @@ suite('<bookmarks-store>', function() {
assertEquals(TEST_TREE.children[2], store.idToNodeMap_['5']);
});
- test('changing selectedId changes the selectedNode', function(){
+ test('changing selectedId changes the displayedList', function(){
store.selectedId = '0';
- assertEquals(TEST_TREE, store.selectedNode);
+ assertEquals(TEST_TREE.children, store.displayedList);
store.selectedId = '1';
- assertEquals(TEST_TREE.children[0], store.selectedNode);
+ assertEquals(TEST_TREE.children[0].children, store.displayedList);
store.selectedId = '2';
- assertEquals(TEST_TREE.children[0].children[0], store.selectedNode);
+ assertEquals(
+ TEST_TREE.children[0].children[0].children, store.displayedList);
store.selectedId = '3';
- assertEquals(TEST_TREE.children[0].children[1], store.selectedNode);
+ assertEquals(
+ TEST_TREE.children[0].children[1].children, store.displayedList);
store.selectedId = '4';
- assertEquals(TEST_TREE.children[1], store.selectedNode);
+ assertEquals(TEST_TREE.children[1].children, store.displayedList);
store.selectedId = '5';
- assertEquals(TEST_TREE.children[2], store.selectedNode);
+ assertEquals(TEST_TREE.children[2].children, store.displayedList);
});
test('correct paths generated for nodes', function() {
@@ -168,6 +170,39 @@ suite('<bookmarks-store>', function() {
assertEquals('0', store.selectedId);
});
+ test('displayedList updates after searchTerm changes', function() {
+ var SEARCH_RESULTS = [
+ 'cat',
+ 'apple',
+ 'Paris',
+ ];
+
+ chrome.bookmarks.search = function(searchTerm, callback) {
tsergeant 2017/01/13 01:56:23 No need to do anything here, but it'd be good to d
+ callback(SEARCH_RESULTS);
+ };
+
+ // Search for a non-empty string.
+ store.searchTerm = 'a';
+ assertFalse(store.rootNode.children[0].isSelected);
+ assertEquals(null, store.selectedId);
+ assertEquals(SEARCH_RESULTS, store.displayedList);
+
+ // Clear the searchTerm.
+ store.searchTerm = '';
+ var defaultFolder = store.rootNode.children[0];
+ assertTrue(defaultFolder.isSelected);
+ assertEquals(defaultFolder.id, store.selectedId);
+ assertEquals(defaultFolder.children, store.displayedList);
+
+ // Search with no bookmarks returned.
+ var EMPTY_RESULT = [];
+ chrome.bookmarks.search = function(searchTerm, callback) {
+ callback(EMPTY_RESULT);
+ };
+ store.searchTerm = 'asdf';
+ assertEquals(EMPTY_RESULT, store.displayedList);
+ });
+
test('bookmark gets updated after editing', function() {
// Edit title updates idToNodeMap_ properly.
store.onBookmarkChanged_('4', {'title': 'test'});
« no previous file with comments | « chrome/browser/resources/md_bookmarks/toolbar.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698