third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

diff --git a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

index 060c66f89195f31b31daa50b731e2c50532e69a7..ca99bb08c3654952f0f7d3603561790f2a3b6662 100644

--- a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

+++ b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp

@@ -64,7 +64,7 @@ void FaceDetector::onDetectFaces(

HeapVector<Member<DetectedFace>> detectedFaces;

for (const auto& boundingBox : faceDetectionResult->bounding_boxes) {

- detectedFaces.append(DetectedFace::create(

+ detectedFaces.push_back(DetectedFace::create(

DOMRect::create(boundingBox->x, boundingBox->y, boundingBox->width,

boundingBox->height)));

}