Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
index de940f2e6801bba072c4e9a00ca212f48ea4dacd..7163faa7fab29b637b137ec6ec815512d49b438e 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
@@ -279,14 +279,14 @@ WebRTCConfiguration parseConfiguration(ExecutionContext* context,
UseCounter::count(context, UseCounter::RTCIceServerURLs);
const StringOrStringSequence& urls = iceServer.urls();
if (urls.isString()) {
- urlStrings.append(urls.getAsString());
+ urlStrings.push_back(urls.getAsString());
} else {
DCHECK(urls.isStringSequence());
urlStrings = urls.getAsStringSequence();
}
} else if (iceServer.hasURL()) {
UseCounter::count(context, UseCounter::RTCIceServerURL);
- urlStrings.append(iceServer.url());
+ urlStrings.push_back(iceServer.url());
} else {
exceptionState.throwTypeError("Malformed RTCIceServer");
return WebRTCConfiguration();
@@ -317,7 +317,7 @@ WebRTCConfiguration parseConfiguration(ExecutionContext* context,
"required when the URL scheme is "
"\"turn\" or \"turns\".");
}
- iceServers.append(WebRTCIceServer{url, username, credential});
+ iceServers.push_back(WebRTCIceServer{url, username, credential});
}
}
webConfiguration.iceServers = iceServers;
@@ -1076,7 +1076,7 @@ void RTCPeerConnection::addStream(ExecutionContext* context,
return;
}
- m_localStreams.append(stream);
+ m_localStreams.push_back(stream);
bool valid = m_peerHandler->addStream(stream->descriptor(), constraints);
if (!valid)
@@ -1287,7 +1287,7 @@ void RTCPeerConnection::didAddRemoteStream(const WebMediaStream& remoteStream) {
MediaStream* stream =
MediaStream::create(getExecutionContext(), remoteStream);
- m_remoteStreams.append(stream);
+ m_remoteStreams.push_back(stream);
scheduleDispatchEvent(
MediaStreamEvent::create(EventTypeNames::addstream, stream));
@@ -1421,7 +1421,8 @@ void RTCPeerConnection::scheduleDispatchEvent(Event* event) {
void RTCPeerConnection::scheduleDispatchEvent(
Event* event,
std::unique_ptr<BoolFunction> setupFunction) {
- m_scheduledEvents.append(new EventWrapper(event, std::move(setupFunction)));
+ m_scheduledEvents.push_back(
+ new EventWrapper(event, std::move(setupFunction)));
m_dispatchScheduledEventRunner->runAsync();
}

Powered by Google App Engine
This is Rietveld 408576698