Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index 5878b4d0cdacf38af24653eb84b00c7688648d9a..15d2f3d563e3398970e44a7b5154e9ccf7a40930 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -186,7 +186,7 @@ void validateAndConvertDisplayItems(const HeapVector<PaymentItem>& input,
validateShippingOptionOrPaymentItem(item, exceptionState);
if (exceptionState.hadException())
return;
- output.append(payments::mojom::blink::PaymentItem::From(item));
+ output.push_back(payments::mojom::blink::PaymentItem::From(item));
}
}
@@ -218,7 +218,8 @@ void validateAndConvertShippingOptions(
if (exceptionState.hadException())
return;
- output.append(payments::mojom::blink::PaymentShippingOption::From(option));
+ output.push_back(
+ payments::mojom::blink::PaymentShippingOption::From(option));
}
}
@@ -268,7 +269,7 @@ void maybeSetAndroidPayMethodData(const ScriptValue& input,
for (const String& allowedCardNetwork : androidPay.allowedCardNetworks()) {
for (size_t i = 0; i < arraysize(kAndroidPayNetwork); ++i) {
if (allowedCardNetwork == kAndroidPayNetwork[i].name) {
- output->allowed_card_networks.append(kAndroidPayNetwork[i].code);
+ output->allowed_card_networks.push_back(kAndroidPayNetwork[i].code);
break;
}
}
@@ -299,7 +300,7 @@ void maybeSetAndroidPayMethodData(const ScriptValue& input,
for (const String& key : keys) {
if (!DictionaryHelper::get(tokenization.parameters(), key, value))
continue;
- output->parameters.append(
+ output->parameters.push_back(
payments::mojom::blink::AndroidPayTokenizationParameter::New());
output->parameters.back()->key = key;
output->parameters.back()->value = value;
@@ -341,7 +342,7 @@ void validateAndConvertPaymentDetailsModifiers(
}
for (const PaymentDetailsModifier& modifier : input) {
- output.append(payments::mojom::blink::PaymentDetailsModifier::New());
+ output.push_back(payments::mojom::blink::PaymentDetailsModifier::New());
if (modifier.hasTotal()) {
validateAndConvertTotal(modifier.total(), output.back()->total,
exceptionState);
@@ -453,7 +454,7 @@ void validateAndConvertPaymentMethodData(
return;
}
- output.append(payments::mojom::blink::PaymentMethodData::New());
+ output.push_back(payments::mojom::blink::PaymentMethodData::New());
output.back()->supported_methods = paymentMethodData.supportedMethods();
if (paymentMethodData.hasData() && !paymentMethodData.data().isEmpty()) {

Powered by Google App Engine
This is Rietveld 408576698