Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
index c565426b0951fa5467d7bc347d5f43e9e5c24905..eb264fc86da8821833e6ec5ee7e3564d8899a17e 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
+++ b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
@@ -57,7 +57,7 @@ class NotificationDataTest : public ::testing::Test {
TEST_F(NotificationDataTest, ReflectProperties) {
Vector<unsigned> vibrationPattern;
for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibration); ++i)
- vibrationPattern.append(kNotificationVibration[i]);
+ vibrationPattern.push_back(kNotificationVibration[i]);
UnsignedLongOrUnsignedLongSequence vibrationSequence;
vibrationSequence.setUnsignedLongSequence(vibrationPattern);
@@ -71,7 +71,7 @@ TEST_F(NotificationDataTest, ReflectProperties) {
action.setIcon(kNotificationActionIcon);
action.setPlaceholder(kNotificationActionPlaceholder);
- actions.append(action);
+ actions.push_back(action);
}
NotificationOptions options;
@@ -129,7 +129,7 @@ TEST_F(NotificationDataTest, ReflectProperties) {
TEST_F(NotificationDataTest, SilentNotificationWithVibration) {
Vector<unsigned> vibrationPattern;
for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibration); ++i)
- vibrationPattern.append(kNotificationVibration[i]);
+ vibrationPattern.push_back(kNotificationVibration[i]);
UnsignedLongOrUnsignedLongSequence vibrationSequence;
vibrationSequence.setUnsignedLongSequence(vibrationPattern);
@@ -152,7 +152,7 @@ TEST_F(NotificationDataTest, ActionTypeButtonWithPlaceholder) {
NotificationAction action;
action.setType("button");
action.setPlaceholder("I'm afraid I can't do that...");
- actions.append(action);
+ actions.push_back(action);
NotificationOptions options;
options.setActions(actions);
@@ -188,7 +188,7 @@ TEST_F(NotificationDataTest, InvalidIconUrls) {
action.setAction(kNotificationActionAction);
action.setTitle(kNotificationActionTitle);
action.setIcon(kNotificationIconInvalid);
- actions.append(action);
+ actions.push_back(action);
}
NotificationOptions options;
@@ -213,7 +213,7 @@ TEST_F(NotificationDataTest, VibrationNormalization) {
Vector<unsigned> unnormalizedPattern;
for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibrationUnnormalized);
++i)
- unnormalizedPattern.append(kNotificationVibrationUnnormalized[i]);
+ unnormalizedPattern.push_back(kNotificationVibrationUnnormalized[i]);
UnsignedLongOrUnsignedLongSequence vibrationSequence;
vibrationSequence.setUnsignedLongSequence(unnormalizedPattern);
@@ -229,7 +229,7 @@ TEST_F(NotificationDataTest, VibrationNormalization) {
Vector<int> normalizedPattern;
for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibrationNormalized);
++i)
- normalizedPattern.append(kNotificationVibrationNormalized[i]);
+ normalizedPattern.push_back(kNotificationVibrationNormalized[i]);
ASSERT_EQ(normalizedPattern.size(), notificationData.vibrate.size());
for (size_t i = 0; i < normalizedPattern.size(); ++i)
@@ -279,7 +279,7 @@ TEST_F(NotificationDataTest, MaximumActionCount) {
action.setAction(String::number(i));
action.setTitle(kNotificationActionTitle);
- actions.append(action);
+ actions.push_back(action);
}
NotificationOptions options;

Powered by Google App Engine
This is Rietveld 408576698