third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp ('k') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp

diff --git a/third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp b/third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp

index d079eee2b1ddafbcfd7352b4ba301eb445d67e11..f26115e1cf8627c9ab101cb565a60f755f3cb745 100644

--- a/third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp

+++ b/third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp

@@ -74,7 +74,7 @@ blink::mojom::blink::MediaImagePtr sanitizeMediaImageAndConvertToMojo(

mojoImage->type = image->type().left(kMaxImageTypeLength);

for (const auto& webSize :

WebIconSizesParser::parseIconSizes(image->sizes())) {

- mojoImage->sizes.append(webSize);

+ mojoImage->sizes.push_back(webSize);

if (mojoImage->sizes.size() == kMaxNumberOfImageSizes) {

context->addConsoleMessage(ConsoleMessage::create(

JSMessageSource, WarningMessageLevel,

@@ -105,7 +105,7 @@ MediaMetadataSanitizer::sanitizeAndConvertToMojo(const MediaMetadata* metadata,

blink::mojom::blink::MediaImagePtr mojoImage =

sanitizeMediaImageAndConvertToMojo(image.get(), context);

if (!mojoImage.is_null())

- mojoMetadata->artwork.append(std::move(mojoImage));

+ mojoMetadata->artwork.push_back(std::move(mojoImage));

if (mojoMetadata->artwork.size() == kMaxNumberOfMediaImages) {

context->addConsoleMessage(ConsoleMessage::create(

JSMessageSource, WarningMessageLevel,