Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
index ef5253d75220e95c00ebd1f268f1020a3f9c7d43..4d79646b8b4888aedc6a279f347ac744feda7d4e 100644
--- a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
@@ -38,7 +38,7 @@ std::unique_ptr<WebServiceWorkerResponse> createTestWebServiceWorkerResponse() {
{"foo", "bar"},
{0, 0}};
Vector<WebURL> urlList;
- urlList.append(url);
+ urlList.push_back(url);
std::unique_ptr<WebServiceWorkerResponse> webResponse =
WTF::makeUnique<WebServiceWorkerResponse>();
webResponse->setURLList(urlList);
@@ -58,7 +58,7 @@ TEST(ServiceWorkerResponseTest, FromFetchResponseData) {
FetchResponseData* fetchResponseData = FetchResponseData::create();
Vector<KURL> urlList;
- urlList.append(url);
+ urlList.push_back(url);
fetchResponseData->setURLList(urlList);
Response* response = Response::create(&page->document(), fetchResponseData);
ASSERT(response);
@@ -228,7 +228,7 @@ TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault) {
FetchResponseData* fetchResponseData =
FetchResponseData::createWithBuffer(buffer);
Vector<KURL> urlList;
- urlList.append(KURL(ParsedURLString, "http://www.response.com"));
+ urlList.push_back(KURL(ParsedURLString, "http://www.response.com"));
fetchResponseData->setURLList(urlList);
Response* response =
Response::create(scope.getExecutionContext(), fetchResponseData);
@@ -242,7 +242,7 @@ TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneBasic) {
FetchResponseData* fetchResponseData =
FetchResponseData::createWithBuffer(buffer);
Vector<KURL> urlList;
- urlList.append(KURL(ParsedURLString, "http://www.response.com"));
+ urlList.push_back(KURL(ParsedURLString, "http://www.response.com"));
fetchResponseData->setURLList(urlList);
fetchResponseData = fetchResponseData->createBasicFilteredResponse();
Response* response =
@@ -257,7 +257,7 @@ TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneCORS) {
FetchResponseData* fetchResponseData =
FetchResponseData::createWithBuffer(buffer);
Vector<KURL> urlList;
- urlList.append(KURL(ParsedURLString, "http://www.response.com"));
+ urlList.push_back(KURL(ParsedURLString, "http://www.response.com"));
fetchResponseData->setURLList(urlList);
fetchResponseData = fetchResponseData->createCORSFilteredResponse();
Response* response =
@@ -272,7 +272,7 @@ TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneOpaque) {
FetchResponseData* fetchResponseData =
FetchResponseData::createWithBuffer(buffer);
Vector<KURL> urlList;
- urlList.append(KURL(ParsedURLString, "http://www.response.com"));
+ urlList.push_back(KURL(ParsedURLString, "http://www.response.com"));
fetchResponseData->setURLList(urlList);
fetchResponseData = fetchResponseData->createOpaqueFilteredResponse();
Response* response =
@@ -289,7 +289,7 @@ TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneError) {
FetchResponseData* fetchResponseData =
FetchResponseData::createWithBuffer(buffer);
Vector<KURL> urlList;
- urlList.append(KURL(ParsedURLString, "http://www.response.com"));
+ urlList.push_back(KURL(ParsedURLString, "http://www.response.com"));
fetchResponseData->setURLList(urlList);
Response* response =
Response::create(scope.getExecutionContext(), fetchResponseData);

Powered by Google App Engine
This is Rietveld 408576698