Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/shapedetection/BarcodeDetector.h" 5 #include "modules/shapedetection/BarcodeDetector.h"
6 6
7 #include "core/dom/DOMException.h" 7 #include "core/dom/DOMException.h"
8 #include "core/dom/DOMRect.h" 8 #include "core/dom/DOMRect.h"
9 #include "core/frame/LocalDOMWindow.h" 9 #include "core/frame/LocalDOMWindow.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 DCHECK(m_barcodeServiceRequests.contains(resolver)); 52 DCHECK(m_barcodeServiceRequests.contains(resolver));
53 m_barcodeServiceRequests.remove(resolver); 53 m_barcodeServiceRequests.remove(resolver);
54 54
55 HeapVector<Member<DetectedBarcode>> detectedBarcodes; 55 HeapVector<Member<DetectedBarcode>> detectedBarcodes;
56 for (const auto& barcode : barcodeDetectionResults) { 56 for (const auto& barcode : barcodeDetectionResults) {
57 HeapVector<Point2D> cornerPoints; 57 HeapVector<Point2D> cornerPoints;
58 for (const auto& corner_point : barcode->corner_points) { 58 for (const auto& corner_point : barcode->corner_points) {
59 Point2D point; 59 Point2D point;
60 point.setX(corner_point->x); 60 point.setX(corner_point->x);
61 point.setY(corner_point->y); 61 point.setY(corner_point->y);
62 cornerPoints.append(point); 62 cornerPoints.push_back(point);
63 } 63 }
64 detectedBarcodes.append(DetectedBarcode::create( 64 detectedBarcodes.push_back(DetectedBarcode::create(
65 barcode->raw_value, 65 barcode->raw_value,
66 DOMRect::create(barcode->bounding_box->x, barcode->bounding_box->y, 66 DOMRect::create(barcode->bounding_box->x, barcode->bounding_box->y,
67 barcode->bounding_box->width, 67 barcode->bounding_box->width,
68 barcode->bounding_box->height), 68 barcode->bounding_box->height),
69 cornerPoints)); 69 cornerPoints));
70 } 70 }
71 71
72 resolver->resolve(detectedBarcodes); 72 resolver->resolve(detectedBarcodes);
73 } 73 }
74 74
75 void BarcodeDetector::onBarcodeServiceConnectionError() { 75 void BarcodeDetector::onBarcodeServiceConnectionError() {
76 for (const auto& request : m_barcodeServiceRequests) { 76 for (const auto& request : m_barcodeServiceRequests) {
77 request->reject(DOMException::create(NotSupportedError, 77 request->reject(DOMException::create(NotSupportedError,
78 "Barcode Detection not implemented.")); 78 "Barcode Detection not implemented."));
79 } 79 }
80 m_barcodeServiceRequests.clear(); 80 m_barcodeServiceRequests.clear();
81 m_barcodeService.reset(); 81 m_barcodeService.reset();
82 } 82 }
83 83
84 DEFINE_TRACE(BarcodeDetector) { 84 DEFINE_TRACE(BarcodeDetector) {
85 ShapeDetector::trace(visitor); 85 ShapeDetector::trace(visitor);
86 visitor->trace(m_barcodeServiceRequests); 86 visitor->trace(m_barcodeServiceRequests);
87 } 87 }
88 88
89 } // namespace blink 89 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698