Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/payments/PaymentResponse.h" 5 #include "modules/payments/PaymentResponse.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "bindings/core/v8/V8Binding.h" 10 #include "bindings/core/v8/V8Binding.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 input->method_name = "foo"; 128 input->method_name = "foo";
129 input->stringified_details = "{\"transactionId\": 123}"; 129 input->stringified_details = "{\"transactionId\": 123}";
130 input->shipping_option = "standardShippingOption"; 130 input->shipping_option = "standardShippingOption";
131 input->payer_email = "abc@gmail.com"; 131 input->payer_email = "abc@gmail.com";
132 input->payer_phone = "0123"; 132 input->payer_phone = "0123";
133 input->payer_name = "Jon Doe"; 133 input->payer_name = "Jon Doe";
134 input->shipping_address = payments::mojom::blink::PaymentAddress::New(); 134 input->shipping_address = payments::mojom::blink::PaymentAddress::New();
135 input->shipping_address->country = "US"; 135 input->shipping_address->country = "US";
136 input->shipping_address->language_code = "en"; 136 input->shipping_address->language_code = "en";
137 input->shipping_address->script_code = "Latn"; 137 input->shipping_address->script_code = "Latn";
138 input->shipping_address->address_line.append("340 Main St"); 138 input->shipping_address->address_line.push_back("340 Main St");
139 input->shipping_address->address_line.append("BIN1"); 139 input->shipping_address->address_line.push_back("BIN1");
140 input->shipping_address->address_line.append("First floor"); 140 input->shipping_address->address_line.push_back("First floor");
141 141
142 PaymentResponse output(std::move(input), new MockPaymentCompleter); 142 PaymentResponse output(std::move(input), new MockPaymentCompleter);
143 ScriptValue jsonObject = output.toJSONForBinding(scope.getScriptState()); 143 ScriptValue jsonObject = output.toJSONForBinding(scope.getScriptState());
144 EXPECT_TRUE(jsonObject.isObject()); 144 EXPECT_TRUE(jsonObject.isObject());
145 145
146 String jsonString = v8StringToWebCoreString<String>( 146 String jsonString = v8StringToWebCoreString<String>(
147 v8::JSON::Stringify(scope.context(), 147 v8::JSON::Stringify(scope.context(),
148 jsonObject.v8Value().As<v8::Object>()) 148 jsonObject.v8Value().As<v8::Object>())
149 .ToLocalChecked(), 149 .ToLocalChecked(),
150 DoNotExternalize); 150 DoNotExternalize);
151 String expected = 151 String expected =
152 "{\"methodName\":\"foo\",\"details\":{\"transactionId\":123}," 152 "{\"methodName\":\"foo\",\"details\":{\"transactionId\":123},"
153 "\"shippingAddress\":{\"country\":\"US\",\"addressLine\":[\"340 Main " 153 "\"shippingAddress\":{\"country\":\"US\",\"addressLine\":[\"340 Main "
154 "St\"," 154 "St\","
155 "\"BIN1\",\"First " 155 "\"BIN1\",\"First "
156 "floor\"],\"region\":\"\",\"city\":\"\",\"dependentLocality\":" 156 "floor\"],\"region\":\"\",\"city\":\"\",\"dependentLocality\":"
157 "\"\",\"postalCode\":\"\",\"sortingCode\":\"\",\"languageCode\":\"en-" 157 "\"\",\"postalCode\":\"\",\"sortingCode\":\"\",\"languageCode\":\"en-"
158 "Latn\"," 158 "Latn\","
159 "\"organization\":\"\",\"recipient\":\"\",\"phone\":\"\"}," 159 "\"organization\":\"\",\"recipient\":\"\",\"phone\":\"\"},"
160 "\"shippingOption\":" 160 "\"shippingOption\":"
161 "\"standardShippingOption\",\"payerName\":\"Jon Doe\"," 161 "\"standardShippingOption\",\"payerName\":\"Jon Doe\","
162 "\"payerEmail\":\"abc@gmail.com\",\"payerPhone\":\"0123\"}"; 162 "\"payerEmail\":\"abc@gmail.com\",\"payerPhone\":\"0123\"}";
163 EXPECT_EQ(expected, jsonString); 163 EXPECT_EQ(expected, jsonString);
164 } 164 }
165 165
166 } // namespace 166 } // namespace
167 } // namespace blink 167 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698