Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/FetchManager.h" 5 #include "modules/fetch/FetchManager.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "bindings/core/v8/ScriptState.h" 9 #include "bindings/core/v8/ScriptState.h"
10 #include "bindings/core/v8/V8ThrowException.h" 10 #include "bindings/core/v8/V8ThrowException.h"
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 : m_fetchManager(fetchManager), 296 : m_fetchManager(fetchManager),
297 m_resolver(resolver), 297 m_resolver(resolver),
298 m_request(request), 298 m_request(request),
299 m_failed(false), 299 m_failed(false),
300 m_finished(false), 300 m_finished(false),
301 m_responseHttpStatusCode(0), 301 m_responseHttpStatusCode(0),
302 m_integrityVerifier(nullptr), 302 m_integrityVerifier(nullptr),
303 m_didFinishLoading(false), 303 m_didFinishLoading(false),
304 m_isIsolatedWorld(isIsolatedWorld), 304 m_isIsolatedWorld(isIsolatedWorld),
305 m_executionContext(executionContext) { 305 m_executionContext(executionContext) {
306 m_urlList.append(request->url()); 306 m_urlList.push_back(request->url());
307 } 307 }
308 308
309 FetchManager::Loader::~Loader() { 309 FetchManager::Loader::~Loader() {
310 ASSERT(!m_loader); 310 ASSERT(!m_loader);
311 } 311 }
312 312
313 DEFINE_TRACE(FetchManager::Loader) { 313 DEFINE_TRACE(FetchManager::Loader) {
314 visitor->trace(m_fetchManager); 314 visitor->trace(m_fetchManager);
315 visitor->trace(m_resolver); 315 visitor->trace(m_resolver);
316 visitor->trace(m_request); 316 visitor->trace(m_request);
317 visitor->trace(m_loader); 317 visitor->trace(m_loader);
318 visitor->trace(m_integrityVerifier); 318 visitor->trace(m_integrityVerifier);
319 visitor->trace(m_executionContext); 319 visitor->trace(m_executionContext);
320 } 320 }
321 321
322 void FetchManager::Loader::didReceiveRedirectTo(const KURL& url) { 322 void FetchManager::Loader::didReceiveRedirectTo(const KURL& url) {
323 m_urlList.append(url); 323 m_urlList.push_back(url);
324 } 324 }
325 325
326 void FetchManager::Loader::didReceiveResponse( 326 void FetchManager::Loader::didReceiveResponse(
327 unsigned long, 327 unsigned long,
328 const ResourceResponse& response, 328 const ResourceResponse& response,
329 std::unique_ptr<WebDataConsumerHandle> handle) { 329 std::unique_ptr<WebDataConsumerHandle> handle) {
330 ASSERT(handle); 330 ASSERT(handle);
331 // TODO(horo): This check could be false when we will use the response url 331 // TODO(horo): This check could be false when we will use the response url
332 // in service worker responses. (crbug.com/553535) 332 // in service worker responses. (crbug.com/553535)
333 DCHECK(response.url() == m_urlList.back()); 333 DCHECK(response.url() == m_urlList.back());
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 m_loaders.remove(loader); 931 m_loaders.remove(loader);
932 loader->dispose(); 932 loader->dispose();
933 } 933 }
934 934
935 DEFINE_TRACE(FetchManager) { 935 DEFINE_TRACE(FetchManager) {
936 visitor->trace(m_loaders); 936 visitor->trace(m_loaders);
937 ContextLifecycleObserver::trace(visitor); 937 ContextLifecycleObserver::trace(visitor);
938 } 938 }
939 939
940 } // namespace blink 940 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698