Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/csspaint/PaintWorkletGlobalScope.h" 5 #include "modules/csspaint/PaintWorkletGlobalScope.h"
6 6
7 #include "bindings/core/v8/V8BindingMacros.h" 7 #include "bindings/core/v8/V8BindingMacros.h"
8 #include "bindings/core/v8/WorkerOrWorkletScriptController.h" 8 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
9 #include "core/CSSPropertyNames.h" 9 #include "core/CSSPropertyNames.h"
10 #include "core/dom/ExceptionCode.h" 10 #include "core/dom/ExceptionCode.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 if (!isUndefinedOrNull(inputPropertiesValue)) { 89 if (!isUndefinedOrNull(inputPropertiesValue)) {
90 Vector<String> properties = toImplArray<Vector<String>>( 90 Vector<String> properties = toImplArray<Vector<String>>(
91 inputPropertiesValue, 0, isolate, exceptionState); 91 inputPropertiesValue, 0, isolate, exceptionState);
92 92
93 if (exceptionState.hadException()) 93 if (exceptionState.hadException())
94 return; 94 return;
95 95
96 for (const auto& property : properties) { 96 for (const auto& property : properties) {
97 CSSPropertyID propertyID = cssPropertyID(property); 97 CSSPropertyID propertyID = cssPropertyID(property);
98 if (propertyID == CSSPropertyVariable) { 98 if (propertyID == CSSPropertyVariable) {
99 customInvalidationProperties.append(property); 99 customInvalidationProperties.push_back(property);
100 } else if (propertyID != CSSPropertyInvalid) { 100 } else if (propertyID != CSSPropertyInvalid) {
101 nativeInvalidationProperties.append(propertyID); 101 nativeInvalidationProperties.push_back(propertyID);
102 } 102 }
103 } 103 }
104 } 104 }
105 105
106 // Parse 'alpha' AKA hasAlpha property. 106 // Parse 'alpha' AKA hasAlpha property.
107 v8::Local<v8::Value> alphaValue; 107 v8::Local<v8::Value> alphaValue;
108 if (!v8Call(constructor->Get(context, v8String(isolate, "alpha")), 108 if (!v8Call(constructor->Get(context, v8String(isolate, "alpha")),
109 alphaValue)) 109 alphaValue))
110 return; 110 return;
111 if (!isUndefinedOrNull(alphaValue) && !alphaValue->IsBoolean()) { 111 if (!isUndefinedOrNull(alphaValue) && !alphaValue->IsBoolean()) {
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 set->add(generator); 186 set->add(generator);
187 } 187 }
188 188
189 DEFINE_TRACE(PaintWorkletGlobalScope) { 189 DEFINE_TRACE(PaintWorkletGlobalScope) {
190 visitor->trace(m_paintDefinitions); 190 visitor->trace(m_paintDefinitions);
191 visitor->trace(m_pendingGenerators); 191 visitor->trace(m_pendingGenerators);
192 MainThreadWorkletGlobalScope::trace(visitor); 192 MainThreadWorkletGlobalScope::trace(visitor);
193 } 193 }
194 194
195 } // namespace blink 195 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698