Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/background_sync/SyncManager.h" 5 #include "modules/background_sync/SyncManager.h"
6 6
7 #include "bindings/core/v8/CallbackPromiseAdapter.h" 7 #include "bindings/core/v8/CallbackPromiseAdapter.h"
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "bindings/core/v8/ScriptState.h" 10 #include "bindings/core/v8/ScriptState.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 // static 115 // static
116 void SyncManager::getRegistrationsCallback( 116 void SyncManager::getRegistrationsCallback(
117 ScriptPromiseResolver* resolver, 117 ScriptPromiseResolver* resolver,
118 mojom::blink::BackgroundSyncError error, 118 mojom::blink::BackgroundSyncError error,
119 WTF::Vector<mojom::blink::SyncRegistrationPtr> registrations) { 119 WTF::Vector<mojom::blink::SyncRegistrationPtr> registrations) {
120 // TODO(iclelland): Determine the correct error message to return in each case 120 // TODO(iclelland): Determine the correct error message to return in each case
121 switch (error) { 121 switch (error) {
122 case mojom::blink::BackgroundSyncError::NONE: { 122 case mojom::blink::BackgroundSyncError::NONE: {
123 Vector<String> tags; 123 Vector<String> tags;
124 for (const auto& r : registrations) { 124 for (const auto& r : registrations) {
125 tags.append(r->tag); 125 tags.push_back(r->tag);
126 } 126 }
127 resolver->resolve(tags); 127 resolver->resolve(tags);
128 break; 128 break;
129 } 129 }
130 case mojom::blink::BackgroundSyncError::NOT_FOUND: 130 case mojom::blink::BackgroundSyncError::NOT_FOUND:
131 case mojom::blink::BackgroundSyncError::NOT_ALLOWED: 131 case mojom::blink::BackgroundSyncError::NOT_ALLOWED:
132 case mojom::blink::BackgroundSyncError::PERMISSION_DENIED: 132 case mojom::blink::BackgroundSyncError::PERMISSION_DENIED:
133 // These errors should never be returned from 133 // These errors should never be returned from
134 // BackgroundSyncManager::GetRegistrations 134 // BackgroundSyncManager::GetRegistrations
135 NOTREACHED(); 135 NOTREACHED();
136 break; 136 break;
137 case mojom::blink::BackgroundSyncError::STORAGE: 137 case mojom::blink::BackgroundSyncError::STORAGE:
138 resolver->reject( 138 resolver->reject(
139 DOMException::create(UnknownError, "Background Sync is disabled.")); 139 DOMException::create(UnknownError, "Background Sync is disabled."));
140 break; 140 break;
141 case mojom::blink::BackgroundSyncError::NO_SERVICE_WORKER: 141 case mojom::blink::BackgroundSyncError::NO_SERVICE_WORKER:
142 resolver->reject( 142 resolver->reject(
143 DOMException::create(UnknownError, "No service worker is active.")); 143 DOMException::create(UnknownError, "No service worker is active."));
144 break; 144 break;
145 } 145 }
146 } 146 }
147 147
148 DEFINE_TRACE(SyncManager) { 148 DEFINE_TRACE(SyncManager) {
149 visitor->trace(m_registration); 149 visitor->trace(m_registration);
150 } 150 }
151 151
152 } // namespace blink 152 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698