Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2614663007: Revert "Non-format-changing kernel offset changes" (Closed)

Created:
3 years, 11 months ago by jensj
Modified:
3 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Non-format-changing kernel offset changes" The commit breaks package:compiler. This reverts commit 5edca8c4d3733f319ab2d328aa28ceb286a30904. BUG= Committed: https://github.com/dart-lang/sdk/commit/5215ec6ef2b1264bddb0846bcb91234c36a97b02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -128 lines) Patch
M pkg/kernel/bin/dartk.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 16 chunks +14 lines, -38 lines 0 comments Download
M pkg/kernel/lib/analyzer/loader.dart View 5 chunks +5 lines, -10 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/kernel/lib/clone.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/kernel/lib/frontend/accessors.dart View 2 chunks +13 lines, -15 lines 0 comments Download
M pkg/kernel/lib/kernel.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 7 chunks +1 line, -10 lines 0 comments Download
M pkg/kernel/lib/transformations/async.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/kernel/lib/transformations/continuation.dart View 11 chunks +14 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
tbr
3 years, 11 months ago (2017-01-05 13:19:05 UTC) #2
jensj
Committed patchset #1 (id:1) manually as 5215ec6ef2b1264bddb0846bcb91234c36a97b02 (presubmit successful).
3 years, 11 months ago (2017-01-05 13:19:31 UTC) #4
asgerf
3 years, 11 months ago (2017-01-05 13:58:12 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698