Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2614643003: Document some recent service protocol features (Closed)

Created:
3 years, 11 months ago by Cutch
Modified:
3 years, 11 months ago
Reviewers:
devoncarew, turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Document some recent service protocol features Document the `reloadSources` RPC. Document the `PausePostRequest` pause event. Document the 'IsolateReloaded' event. BUG= R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/ebe7d148f3964b17f1575a731e7d32e96855258d

Patch Set 1 #

Patch Set 2 : Document some recent service protocol features #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service/service.md View 12 chunks +57 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
3 years, 11 months ago (2017-01-04 17:49:03 UTC) #4
devoncarew
lgtm Thanks!
3 years, 11 months ago (2017-01-04 18:49:51 UTC) #5
Cutch
3 years, 11 months ago (2017-01-04 21:45:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ebe7d148f3964b17f1575a731e7d32e96855258d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698