Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26145005: DEFINE_CSS_VALUE_TYPE_CASTS starts to use DEFINE_TYPE_CASTS (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, dglazkov+blink, f(malita), darktears, pdr, apavlov+blink_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DEFINE_CSS_VALUE_TYPE_CASTS starts to use DEFINE_TYPE_CASTS DEFINE_CSS_VALUE_TYPE_CASTS starts to use DEFINE_TYPE_CASTS so that it is more flexible. Under this change, unusual CSS child values will be able to use the DEFINE_CSS_VALUE_TYPE_CASTS as well. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159836

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -47 lines) Patch
M Source/core/css/CSSArrayFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSAspectRatioValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCanvasValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFeatureValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSGridTemplateValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInheritedValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInitialValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSLineBoxContainValue.h View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/css/CSSMixFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSReflectValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSVGDocumentValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShaderValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShadowValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSTimingFunctionValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSTransformValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 1 2 1 chunk +2 lines, -13 lines 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSVariableValue.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
gyuyoung-inactive
7 years, 2 months ago (2013-10-15 03:36:07 UTC) #1
esprehn
Your patch didn't upload properly: "error: old chunk mismatch".
7 years, 2 months ago (2013-10-15 04:48:50 UTC) #2
gyuyoung-inactive
On 2013/10/15 04:48:50, esprehn wrote: > Your patch didn't upload properly: "error: old chunk mismatch". ...
7 years, 2 months ago (2013-10-15 05:46:59 UTC) #3
gyuyoung-inactive
On 2013/10/15 05:46:59, gyuyoung wrote: > On 2013/10/15 04:48:50, esprehn wrote: > > Your patch ...
7 years, 2 months ago (2013-10-16 00:43:14 UTC) #4
tkent
https://chromiumcodereview.appspot.com/26145005/diff/10001/Source/core/css/CSSValue.h File Source/core/css/CSSValue.h (right): https://chromiumcodereview.appspot.com/26145005/diff/10001/Source/core/css/CSSValue.h#newcode25 Source/core/css/CSSValue.h:25: #include "core/dom/Node.h" We don't want this dependency. As we ...
7 years, 2 months ago (2013-10-16 00:59:24 UTC) #5
gyuyoung-inactive
On 2013/10/16 00:59:24, tkent wrote: > https://chromiumcodereview.appspot.com/26145005/diff/10001/Source/core/css/CSSValue.h > File Source/core/css/CSSValue.h (right): > > https://chromiumcodereview.appspot.com/26145005/diff/10001/Source/core/css/CSSValue.h#newcode25 > ...
7 years, 2 months ago (2013-10-16 01:35:01 UTC) #6
gyuyoung-inactive
On 2013/10/16 01:35:01, gyuyoung wrote: > On 2013/10/16 00:59:24, tkent wrote: > > > https://chromiumcodereview.appspot.com/26145005/diff/10001/Source/core/css/CSSValue.h ...
7 years, 2 months ago (2013-10-16 03:37:07 UTC) #7
gyuyoung-inactive
On 2013/10/16 03:37:07, gyuyoung wrote: > On 2013/10/16 01:35:01, gyuyoung wrote: > > On 2013/10/16 ...
7 years, 2 months ago (2013-10-16 03:45:57 UTC) #8
gyuyoung-inactive
On 2013/10/16 03:45:57, gyuyoung wrote: > On 2013/10/16 03:37:07, gyuyoung wrote: > > On 2013/10/16 ...
7 years, 2 months ago (2013-10-16 11:45:20 UTC) #9
tkent
https://chromiumcodereview.appspot.com/26145005/diff/20001/Source/core/svg/SVGColor.h File Source/core/svg/SVGColor.h (right): https://chromiumcodereview.appspot.com/26145005/diff/20001/Source/core/svg/SVGColor.h#newcode97 Source/core/svg/SVGColor.h:97: void toSVGColor(const SVGColor*); This change doesn't look related to ...
7 years, 2 months ago (2013-10-16 21:54:11 UTC) #10
gyuyoung-inactive
https://chromiumcodereview.appspot.com/26145005/diff/20001/Source/core/svg/SVGColor.h File Source/core/svg/SVGColor.h (right): https://chromiumcodereview.appspot.com/26145005/diff/20001/Source/core/svg/SVGColor.h#newcode97 Source/core/svg/SVGColor.h:97: void toSVGColor(const SVGColor*); On 2013/10/16 21:54:11, tkent wrote: > ...
7 years, 2 months ago (2013-10-17 00:03:17 UTC) #11
tkent
lgtm
7 years, 2 months ago (2013-10-17 00:23:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26145005/27001
7 years, 2 months ago (2013-10-17 01:27:19 UTC) #13
commit-bot: I haz the power
Change committed as 159836
7 years, 2 months ago (2013-10-17 07:41:22 UTC) #14
tkent
https://codereview.chromium.org/26145005/diff/27001/Source/core/css/CSSLineBoxContainValue.h File Source/core/css/CSSLineBoxContainValue.h (right): https://codereview.chromium.org/26145005/diff/27001/Source/core/css/CSSLineBoxContainValue.h#newcode59 Source/core/css/CSSLineBoxContainValue.h:59: DEFINE_CSS_VALUE_TYPE_CASTS(CSSLineBoxContainValue, isInitialValue()); isInitialValue() is wrong.
7 years, 2 months ago (2013-10-18 01:16:11 UTC) #15
gyuyoung-inactive
7 years, 2 months ago (2013-10-20 12:11:49 UTC) #16
Message was sent while issue was closed. 
On 2013/10/18 01:16:11, tkent wrote:
>
https://codereview.chromium.org/26145005/diff/27001/Source/core/css/CSSLineBo...
> File Source/core/css/CSSLineBoxContainValue.h (right):
> 
>
https://codereview.chromium.org/26145005/diff/27001/Source/core/css/CSSLineBo...
> Source/core/css/CSSLineBoxContainValue.h:59:
> DEFINE_CSS_VALUE_TYPE_CASTS(CSSLineBoxContainValue, isInitialValue());
> isInitialValue() is wrong.

Oops. I'm really sorry about it. I fixed it.

Powered by Google App Engine
This is Rietveld 408576698