Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: runtime/BUILD.gn

Issue 2614493002: GN: Add option to build with TSAN (Closed)
Patch Set: Fix gyp build as well Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | tools/gn.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/BUILD.gn
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index 6008aecabad0430312d83ca6f0f48e5cbc0a6c30..9423429b74bf62eefe1e9d04dc168f3660da3832 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -168,8 +168,12 @@ config("dart_config") {
cflags += [ "-O3" ]
}
+ ldflags = []
if (defined(is_asan) && is_asan) {
- ldflags = [ "-fsanitize=address" ]
+ ldflags += [ "-fsanitize=address" ]
+ }
+ if (defined(is_tsan) && is_tsan) {
+ ldflags += [ "-fsanitize=thread" ]
}
siva 2017/01/03 20:53:08 should we also add support for MSAN while we are a
zra 2017/01/03 22:36:56 Done.
}
}
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | tools/gn.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698