Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: runtime/BUILD.gn

Issue 2614493002: GN: Add option to build with TSAN (Closed)
Patch Set: Fix gyp build as well Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | tools/gn.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Instead of using is_debug, we introduce a different flag for specifying a 6 # Instead of using is_debug, we introduce a different flag for specifying a
7 # Debug build of Dart so that clients can still use a Release build of Dart 7 # Debug build of Dart so that clients can still use a Release build of Dart
8 # while themselves doing a Debug build. 8 # while themselves doing a Debug build.
9 dart_debug = false 9 dart_debug = false
10 10
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 "-fno-rtti", 161 "-fno-rtti",
162 "-fno-exceptions", 162 "-fno-exceptions",
163 ] 163 ]
164 164
165 if (dart_debug) { 165 if (dart_debug) {
166 cflags += [ "-O1" ] 166 cflags += [ "-O1" ]
167 } else { 167 } else {
168 cflags += [ "-O3" ] 168 cflags += [ "-O3" ]
169 } 169 }
170 170
171 ldflags = []
171 if (defined(is_asan) && is_asan) { 172 if (defined(is_asan) && is_asan) {
172 ldflags = [ "-fsanitize=address" ] 173 ldflags += [ "-fsanitize=address" ]
174 }
175 if (defined(is_tsan) && is_tsan) {
176 ldflags += [ "-fsanitize=thread" ]
173 } 177 }
siva 2017/01/03 20:53:08 should we also add support for MSAN while we are a
zra 2017/01/03 22:36:56 Done.
174 } 178 }
175 } 179 }
176 180
177 template("libdart_library") { 181 template("libdart_library") {
178 extra_configs = [] 182 extra_configs = []
179 if (defined(invoker.extra_configs)) { 183 if (defined(invoker.extra_configs)) {
180 extra_configs += invoker.extra_configs 184 extra_configs += invoker.extra_configs
181 } 185 }
182 extra_deps = [] 186 extra_deps = []
183 if (defined(invoker.extra_deps)) { 187 if (defined(invoker.extra_deps)) {
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 "third_party/double-conversion/src:libdouble_conversion", 298 "third_party/double-conversion/src:libdouble_conversion",
295 "vm:libdart_lib", 299 "vm:libdart_lib",
296 "vm:libdart_lib_nosnapshot", 300 "vm:libdart_lib_nosnapshot",
297 "vm:libdart_vm", 301 "vm:libdart_vm",
298 "vm:libdart_vm_nosnapshot", 302 "vm:libdart_vm_nosnapshot",
299 ] 303 ]
300 sources = [ 304 sources = [
301 "vm/libdart_dependency_helper.cc", 305 "vm/libdart_dependency_helper.cc",
302 ] 306 ]
303 } 307 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | tools/gn.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698