GN: Add option to build with TSAN

GN: Add option to build with TSAN

fixes #28216

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/375322d3abba45bfd66deb6692d124510735aab2

[zra, 2017-01-03 17:28:14]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2017-01-03 17:28:15]

This adds a --tsan option to gn.py, so you'd say e.g.:

./tools/gn.py -m release -a x64 --tsan

and then:

./tools/build.py --gn -m release -a x64

[zra, 2017-01-03 17:41:17]

Description was changed from

==========
GN: Add option to build with TSAN

related #28216
==========

to

==========
GN: Add option to build with TSAN

fixes #28216
==========

[siva, 2017-01-03 20:53:08]

lgtm with comments about adding support for MSAN too.

https://codereview.chromium.org/2614493002/diff/20001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/2614493002/diff/20001/runtime/BUILD.gn#newcod...
runtime/BUILD.gn:177: }
should we also add support for MSAN while we are at it.

(needs options -fsanitize=memory -fPIC)

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py
File tools/gn.py (right):

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode95
tools/gn.py:95: and not args.tsan)
and not args.msan

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode119
tools/gn.py:119: # asan or tsan is specified.
asan,msan or tsan is ...

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode127
tools/gn.py:127: and not args.tsan))  # Use clang for asan builds.
and not args.msan

# Use clang for all sanitizer builds.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode131
tools/gn.py:131: gn_args['is_tsan'] = args.tsan and gn_args['is_clang']
msan too...

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode221
tools/gn.py:221: DART_USE_TSAN = "DART_USE_TSAN"
msan too.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode303
tools/gn.py:303: action='store_false')
msan options too.

[zra, 2017-01-03 22:36:56]

https://codereview.chromium.org/2614493002/diff/20001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/2614493002/diff/20001/runtime/BUILD.gn#newcod...
runtime/BUILD.gn:177: }
On 2017/01/03 20:53:08, siva wrote:
> should we also add support for MSAN while we are at it.
> 
> (needs options -fsanitize=memory -fPIC)

Done.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py
File tools/gn.py (right):

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode95
tools/gn.py:95: and not args.tsan)
On 2017/01/03 20:53:08, siva wrote:
> and not args.msan

Done.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode119
tools/gn.py:119: # asan or tsan is specified.
On 2017/01/03 20:53:08, siva wrote:
> asan,msan or tsan is ...

Done.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode127
tools/gn.py:127: and not args.tsan))  # Use clang for asan builds.
On 2017/01/03 20:53:08, siva wrote:
> and not args.msan
> 
> # Use clang for all sanitizer builds.

Done.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode131
tools/gn.py:131: gn_args['is_tsan'] = args.tsan and gn_args['is_clang']
On 2017/01/03 20:53:08, siva wrote:
> msan too...

Done.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode221
tools/gn.py:221: DART_USE_TSAN = "DART_USE_TSAN"
On 2017/01/03 20:53:08, siva wrote:
> msan too.

Done.

https://codereview.chromium.org/2614493002/diff/20001/tools/gn.py#newcode303
tools/gn.py:303: action='store_false')
On 2017/01/03 20:53:08, siva wrote:
> msan options too.

Done.

[zra, 2017-01-03 22:37:31]

Description was changed from

==========
GN: Add option to build with TSAN

fixes #28216
==========

to

==========
GN: Add option to build with TSAN

fixes #28216

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/375322d3abba45bfd66deb6692d124510735aab2
==========

[zra, 2017-01-03 22:37:32]

Committed patchset #3 (id:40001) manually as
375322d3abba45bfd66deb6692d124510735aab2 (presubmit successful).