Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: remoting/client/gl_renderer_unittest.cc

Issue 2614443003: Moving the GL implementation details into a sub folder for client display. (Closed)
Patch Set: Adding deps restriction on r/c/display; Moving sys_opengl.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/gl_renderer_delegate.h ('k') | remoting/client/gl_texture_ids.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/gl_renderer_unittest.cc
diff --git a/remoting/client/gl_renderer_unittest.cc b/remoting/client/gl_renderer_unittest.cc
deleted file mode 100644
index 1a17e42613203011e1cc34a504be33ae4680d2bc..0000000000000000000000000000000000000000
--- a/remoting/client/gl_renderer_unittest.cc
+++ /dev/null
@@ -1,219 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "remoting/client/gl_renderer.h"
-
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/memory/ptr_util.h"
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
-#include "base/threading/thread_task_runner_handle.h"
-#include "remoting/client/gl_renderer_delegate.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
-
-namespace remoting {
-
-class FakeGlRendererDelegate : public GlRendererDelegate {
- public:
- FakeGlRendererDelegate() : weak_factory_(this) {}
-
- bool CanRenderFrame() override {
- can_render_frame_call_count_++;
- return can_render_frame_;
- }
-
- void OnFrameRendered() override {
- on_frame_rendered_call_count_++;
- if (on_frame_rendered_callback_) {
- on_frame_rendered_callback_.Run();
- }
- }
-
- void OnSizeChanged(int width, int height) override {
- canvas_width_ = width;
- canvas_height_ = height;
- on_size_changed_call_count_++;
- }
-
- void SetOnFrameRenderedCallback(const base::Closure& callback) {
- on_frame_rendered_callback_ = callback;
- }
-
- int canvas_width() {
- return canvas_width_;
- }
-
- int canvas_height() {
- return canvas_height_;
- }
-
- base::WeakPtr<FakeGlRendererDelegate> GetWeakPtr() {
- return weak_factory_.GetWeakPtr();
- }
-
- int can_render_frame_call_count() {
- return can_render_frame_call_count_;
- }
-
- int on_frame_rendered_call_count() {
- return on_frame_rendered_call_count_;
- }
-
- int on_size_changed_call_count() {
- return on_size_changed_call_count_;
- }
-
- bool can_render_frame_ = false;
-
- private:
- int can_render_frame_call_count_ = 0;
- int on_frame_rendered_call_count_ = 0;
- int on_size_changed_call_count_ = 0;
-
- int canvas_width_ = 0;
- int canvas_height_ = 0;
-
- base::Closure on_frame_rendered_callback_;
-
- base::WeakPtrFactory<FakeGlRendererDelegate> weak_factory_;
-};
-
-class GlRendererTest : public testing::Test {
- public:
- void SetUp() override;
- void SetDesktopFrameWithSize(const webrtc::DesktopSize& size);
- void PostSetDesktopFrameTasks(const webrtc::DesktopSize& size, int count);
-
- protected:
- void RequestRender();
- void OnDesktopFrameProcessed();
- void RunTasksInCurrentQueue();
- void RunUntilRendered();
- int on_desktop_frame_processed_call_count() {
- return on_desktop_frame_processed_call_count_;
- }
-
- base::MessageLoop message_loop_;
- std::unique_ptr<GlRenderer> renderer_;
- FakeGlRendererDelegate delegate_;
-
- private:
- int on_desktop_frame_processed_call_count_ = 0;
-};
-
-void GlRendererTest::SetUp() {
- renderer_.reset(new GlRenderer());
- renderer_->SetDelegate(delegate_.GetWeakPtr());
-}
-
-void GlRendererTest::RequestRender() {
- renderer_->RequestRender();
-}
-
-void GlRendererTest::SetDesktopFrameWithSize(const webrtc::DesktopSize& size) {
- renderer_->OnFrameReceived(
- base::MakeUnique<webrtc::BasicDesktopFrame>(size),
- base::Bind(&GlRendererTest::OnDesktopFrameProcessed,
- base::Unretained(this)));
-}
-
-void GlRendererTest::PostSetDesktopFrameTasks(
- const webrtc::DesktopSize& size, int count) {
- for (int i = 0; i < count; i++) {
- message_loop_.task_runner()->PostTask(
- FROM_HERE, base::Bind(&GlRendererTest::SetDesktopFrameWithSize,
- base::Unretained(this), size));
- }
-}
-
-void GlRendererTest::OnDesktopFrameProcessed() {
- on_desktop_frame_processed_call_count_++;
-}
-
-void GlRendererTest::RunTasksInCurrentQueue() {
- base::RunLoop run_loop;
- message_loop_.task_runner()->PostTask(FROM_HERE, run_loop.QuitClosure());
- run_loop.Run();
-}
-
-void GlRendererTest::RunUntilRendered() {
- base::RunLoop run_loop;
- delegate_.SetOnFrameRenderedCallback(run_loop.QuitClosure());
- run_loop.Run();
-}
-
-
-TEST_F(GlRendererTest, TestDelegateCanRenderFrame) {
- delegate_.can_render_frame_ = true;
- RequestRender();
- RunTasksInCurrentQueue();
- EXPECT_EQ(1, delegate_.can_render_frame_call_count());
- EXPECT_EQ(1, delegate_.on_frame_rendered_call_count());
-
- delegate_.can_render_frame_ = false;
- RequestRender();
- RunTasksInCurrentQueue();
- EXPECT_EQ(2, delegate_.can_render_frame_call_count());
- EXPECT_EQ(1, delegate_.on_frame_rendered_call_count());
-}
-
-TEST_F(GlRendererTest, TestRequestRenderOnlyScheduleOnce) {
- delegate_.can_render_frame_ = true;
-
- RequestRender();
- RequestRender();
- RequestRender();
- RunTasksInCurrentQueue();
- EXPECT_EQ(1, delegate_.can_render_frame_call_count());
- EXPECT_EQ(1, delegate_.on_frame_rendered_call_count());
-
- RequestRender();
- RunTasksInCurrentQueue();
- EXPECT_EQ(2, delegate_.can_render_frame_call_count());
- EXPECT_EQ(2, delegate_.on_frame_rendered_call_count());
-}
-
-TEST_F(GlRendererTest, TestDelegateOnSizeChanged) {
- SetDesktopFrameWithSize(webrtc::DesktopSize(16, 16));
- EXPECT_EQ(1, delegate_.on_size_changed_call_count());
- EXPECT_EQ(16, delegate_.canvas_width());
- EXPECT_EQ(16, delegate_.canvas_height());
-
- SetDesktopFrameWithSize(webrtc::DesktopSize(16, 16));
- EXPECT_EQ(1, delegate_.on_size_changed_call_count());
- EXPECT_EQ(16, delegate_.canvas_width());
- EXPECT_EQ(16, delegate_.canvas_height());
-
- SetDesktopFrameWithSize(webrtc::DesktopSize(32, 32));
- EXPECT_EQ(2, delegate_.on_size_changed_call_count());
- EXPECT_EQ(32, delegate_.canvas_width());
- EXPECT_EQ(32, delegate_.canvas_height());
-
- renderer_->RequestCanvasSize();
- EXPECT_EQ(3, delegate_.on_size_changed_call_count());
- EXPECT_EQ(32, delegate_.canvas_width());
- EXPECT_EQ(32, delegate_.canvas_height());
-}
-
-TEST_F(GlRendererTest, TestOnFrameReceivedDoneCallbacks) {
- delegate_.can_render_frame_ = true;
-
- // Implicitly calls RequestRender().
-
- PostSetDesktopFrameTasks(webrtc::DesktopSize(16, 16), 1);
- RunUntilRendered();
- EXPECT_EQ(1, delegate_.on_frame_rendered_call_count());
- EXPECT_EQ(1, on_desktop_frame_processed_call_count());
-
- PostSetDesktopFrameTasks(webrtc::DesktopSize(16, 16), 20);
- RunUntilRendered();
- EXPECT_EQ(2, delegate_.on_frame_rendered_call_count());
- EXPECT_EQ(21, on_desktop_frame_processed_call_count());
-}
-
-// TODO(yuweih): Add tests to validate the rendered output.
-
-} // namespace remoting
« no previous file with comments | « remoting/client/gl_renderer_delegate.h ('k') | remoting/client/gl_texture_ids.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698