Chromium Code Reviews| Index: components/variations/proto/study.proto |
| diff --git a/components/variations/proto/study.proto b/components/variations/proto/study.proto |
| index c97dbb4fff33771b20980b0b5a725761abf2886f..7b327744b3c1b4ee368c7b237981b84e48b2cf98 100644 |
| --- a/components/variations/proto/study.proto |
| +++ b/components/variations/proto/study.proto |
| @@ -17,6 +17,7 @@ message Study { |
| // Ex: "my_study" |
| required string name = 1; |
| + // DEPRECATED: Prefer end_date instead. |
| // The expiry date of the study in Unix time format. (Seconds since midnight |
| // January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time |
| // |
| @@ -38,7 +39,9 @@ message Study { |
| optional Consistency consistency = 7 [default = SESSION]; |
| // Name of the experiment that gets the default experience. This experiment |
| - // must be included in the list below. |
| + // must be included in the list below. If not specified, a dummy experiment |
| + // named "variations_dummy_default" is used, and will have a probability |
|
rkaplow
2017/01/04 15:58:25
this isn't the name you put above
jwd
2017/01/04 21:10:22
Done.
|
| + // weight of 0. |
| // Ex: "default" |
| optional string default_experiment_name = 8; |
| @@ -198,13 +201,22 @@ message Study { |
| // Filtering criteria specifying whether this study is applicable to a given |
| // Chrome instance. |
| // |
| - // Next tag: 13 |
| + // Next tag: 14 |
| message Filter { |
| // The start date of the study in Unix time format. (Seconds since midnight |
| // January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time |
| // Ex: 1330893974 (corresponds to 2012-03-04 20:46:14Z) |
| optional int64 start_date = 1; |
| + // The end date of the study in Unix time format. (Seconds since midnight |
| + // January 1, 1970 UTC). See: http://en.wikipedia.org/wiki/Unix_time |
| + // Ex: 1330893974 (corresponds to 2012-03-04 20:46:14Z) |
| + // Mutually exclusive with expiry_date. The difference between end_date and |
| + // expiry_date is that, when end_date is past, the field trial will not be |
| + // created. When expiry_date is past, the trial is still created, but will |
| + // be disabled, casing it to select it's default group. |
| + optional int64 end_date = 13; |
| + |
| // The minimum Chrome version for this study, allowing a trailing '*' |
| // character for pattern matching. Inclusive. (To check for a match, iterate |
| // over each component checking >= until a * or end of string is reached.) |