components/cronet/tools/cr_cronet.py - Issue 2614423002: [Cronet] Use xcode clang on iOS to reduce release binary size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2614423002: [Cronet] Use xcode clang on iOS to reduce release binary size. (Closed)

Patch Set: Address comments, use is_official_build=true for release builds. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index 8e0b5143ff47b606bafb324ab04df4969ee94124..b8595009ff3a1633c20273eabd31432ec51f9407 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -80,7 +80,8 @@ def main():

if is_os:

target_os = 'ios'

test_target = 'cronet_test'

- gn_args = 'is_cronet_build=true is_component_build=false '

+ gn_args = 'is_cronet_build=true is_component_build=false ' \

+ 'is_official_build=true '

kapishnikov 2017/05/10 17:43:27 Should we build the developer's version by default

mef 2017/05/11 20:04:39 Done. Setting use_xcode_clang=true provides a reas

gn_extra = '--ide=xcode'

if options.iphoneos:

gn_args += ' target_cpu="arm64" '

« no previous file with comments | « no previous file | components/cronet/tools/package_ios.py » ('j') | no next file with comments »