Roll WebGL 046d1f6..da6fe82

Roll WebGL 046d1f6..da6fe82

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f6..da6fe82

BUG=672895, 679679
TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

[yunchao, 2017-01-09 15:04:06]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 15:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 16:07:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 16:07:53]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[yunchao, 2017-01-09 16:23:42]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2017-01-09 16:27:27]

Description was changed from

==========
Roll WebGL 046d1f6..da6fe82

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 046d1f6..da6fe82

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[yunchao, 2017-01-09 16:27:27]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2017-01-09 16:34:53]

We have not roll in webgl CTS into Chromium for 3 weeks. So there are lots of
failures. I have not create specific issues for these failures. Let's do this in
following days. 

PTAL. Hope that the bots can pass...

[yunchao, 2017-01-09 16:55:55]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:56:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-01-09 17:36:35]

On 2017/01/09 16:34:53, yunchao wrote:
> We have not roll in webgl CTS into Chromium for 3 weeks. So there are lots of
> failures. I have not create specific issues for these failures. Let's do this
in
> following days. 
> 
> PTAL. Hope that the bots can pass...

Can you at least create some simple bugs (justing saying xxx is failing on which
platform)? There seems a lot of regression and we need to be on top of it.

[commit-bot: I haz the power, 2017-01-09 18:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:19:44]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)

[yunchao, 2017-01-10 00:45:53]

On 2017/01/09 17:36:35, Zhenyao Mo wrote:
> On 2017/01/09 16:34:53, yunchao wrote:
> > We have not roll in webgl CTS into Chromium for 3 weeks. So there are lots
of
> > failures. I have not create specific issues for these failures. Let's do
this
> in
> > following days. 
> > 
> > PTAL. Hope that the bots can pass...
> 
> Can you at least create some simple bugs (justing saying xxx is failing on
which
> platform)? There seems a lot of regression and we need to be on top of it.

OK, I will create crbugs for these failures today.

[yunchao, 2017-01-10 06:09:14]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:09:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2017-01-10 06:15:33]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:15:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:43:35]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2017-01-10 08:02:25]

Patchset #7 (id:120001) has been deleted

[yunchao, 2017-01-10 11:17:31]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 11:17:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 11:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 11:24:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2017-01-10 13:44:48]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 13:44:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2017-01-10 13:48:04]

Patchset #8 (id:160001) has been deleted

[yunchao, 2017-01-10 16:01:41]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:02:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2017-01-10 16:27:18]

On 2017/01/09 17:36:35, Zhenyao Mo wrote:
> On 2017/01/09 16:34:53, yunchao wrote:
> > We have not roll in webgl CTS into Chromium for 3 weeks. So there are lots
of
> > failures. I have not create specific issues for these failures. Let's do
this
> in
> > following days. 
> > 
> > PTAL. Hope that the bots can pass...
> 
> Can you at least create some simple bugs (justing saying xxx is failing on
which
> platform)? There seems a lot of regression and we need to be on top of it.

Done. crbugs are created for WebGL CTS failures!

[Zhenyao Mo, 2017-01-10 17:11:16]

https://codereview.chromium.org/2614313002/diff/200001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2614313002/diff/200001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:48:
self.Skip('conformance/textures/image_bitmap_from_image_bitmap/*', bug=679677)
Thank you Yunchao.  Can you roll further to include the fixes you submitted?  So
we don't have to take out tests.  Whenever we lose text coverage, something will
land to break the functionality. If we could, let's minimize it.

[commit-bot: I haz the power, 2017-01-10 17:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 17:57:11]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[yunchao, 2017-01-11 00:19:33]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 00:20:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 00:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:30:30]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2017-01-11 03:16:59]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 03:17:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 03:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 03:26:16]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2017-01-11 06:22:15]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:22:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:31:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:31:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yunchao, 2017-01-11 07:00:05]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 07:00:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:02:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[yunchao, 2017-01-11 07:03:52]

Patchset #12 (id:260001) has been deleted

[yunchao, 2017-01-11 09:21:51]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 09:22:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 10:19:49]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[yunchao, 2017-01-11 13:55:28]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 13:55:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 14:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 14:59:41]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[yunchao, 2017-01-11 15:42:01]

Thanks for your suggestion, Zhenyao. I rolled in the latest WebGL CTS at
https://codereview.chromium.org/2626963002/. All bots are green now.

https://codereview.chromium.org/2614313002/diff/200001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2614313002/diff/200001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:48:
self.Skip('conformance/textures/image_bitmap_from_image_bitmap/*', bug=679677)
On 2017/01/10 17:11:16, Zhenyao Mo wrote:
> Thank you Yunchao.  Can you roll further to include the fixes you submitted? 
So
> we don't have to take out tests.  Whenever we lose text coverage, something
will
> land to break the functionality. If we could, let's minimize it.

OK. I rolled the latest WebGL CTS in another patch. PTAL.

[Ken Russell (switch to Gerrit), 2017-01-11 19:25:11]

Thanks for working on this Yunchao. A few more issues.

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:48:
self.Skip('conformance/textures/image_bitmap_from_image_bitmap/*', bug=679677)
These failures are supposed to be resolved now, correct? Could you remove these
expectations?

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:57: bug=679678)
The fix for this just landed upstream, correct? Could you remove this
expectation?

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:75: ['win'],
bug=679679)
This test is passing now that the fix for http://crbug.com/672895 has landed;
check your win_optional_gpu_tests_rel results. Could you remove this
expectation?

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:640: ['linux',
'nvidia'], bug=679677)
The test:
WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_3d_rgba8ui_rgba_integer_unsigned_byte

failed in your linux_optional_gpu_tests_rel run here. Is that a known issue?
Does it need to be suppressed?

Could you file a different bug about just these two failures? Issue 679677 is
now closed.

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right):

https://codereview.chromium.org/2614313002/diff/280001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/webgl_conformance_expectations.py:123: bug=679677)
Please remove these expectations.

[Ken Russell (switch to Gerrit), 2017-01-11 19:26:00]

Description was changed from

==========
Roll WebGL 046d1f6..da6fe82

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 046d1f6..da6fe82

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f...

BUG=672895, 679679

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-01-11 19:45:55]

Ah, I see that this was subsumed by https://codereview.chromium.org/2626963002/
. Closing this.