Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Side by Side Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc

Issue 2614203002: Record data use of user traffic by different core page transition types (Closed)
Patch Set: Addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/data_use_measurement/chrome_data_use_ascriber.h" 5 #include "chrome/browser/data_use_measurement/chrome_data_use_ascriber.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "chrome/browser/data_use_measurement/chrome_data_use_recorder.h" 10 #include "chrome/browser/data_use_measurement/chrome_data_use_recorder.h"
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 << "; gurl: " << gurl.spec(); 351 << "; gurl: " << gurl.spec();
352 if (!data_use.url().is_valid()) { 352 if (!data_use.url().is_valid()) {
353 data_use.set_url(gurl); 353 data_use.set_url(gurl);
354 } 354 }
355 355
356 main_render_frame_data_use_map_.insert(std::make_pair( 356 main_render_frame_data_use_map_.insert(std::make_pair(
357 RenderFrameHostID(render_process_id, render_frame_id), entry)); 357 RenderFrameHostID(render_process_id, render_frame_id), entry));
358 } 358 }
359 } 359 }
360 360
361 void ChromeDataUseAscriber::DidFinishNavigation(int render_process_id,
362 int render_frame_id,
363 uint32_t page_transition) {
364 auto frame_it = main_render_frame_data_use_map_.find(
365 RenderFrameHostID(render_process_id, render_frame_id));
366 if (frame_it != main_render_frame_data_use_map_.end()) {
367 frame_it->second->set_page_transition(page_transition);
368 }
369 }
370
361 void ChromeDataUseAscriber::OnDataUseCompleted(DataUseRecorderEntry entry) { 371 void ChromeDataUseAscriber::OnDataUseCompleted(DataUseRecorderEntry entry) {
362 // TODO(ryansturm): Notify observers that data use is complete. 372 // TODO(ryansturm): Notify observers that data use is complete.
363 } 373 }
364 374
365 std::unique_ptr<URLRequestClassifier> 375 std::unique_ptr<URLRequestClassifier>
366 ChromeDataUseAscriber::CreateURLRequestClassifier() const { 376 ChromeDataUseAscriber::CreateURLRequestClassifier() const {
367 return base::MakeUnique<ContentURLRequestClassifier>(); 377 return base::MakeUnique<ContentURLRequestClassifier>();
368 } 378 }
369 379
370 ChromeDataUseAscriber::DataUseRecorderEntry 380 ChromeDataUseAscriber::DataUseRecorderEntry
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 int new_render_process_id, 412 int new_render_process_id,
403 int new_render_frame_id) { 413 int new_render_frame_id) {
404 if (visible_main_render_frames_.find( 414 if (visible_main_render_frames_.find(
405 RenderFrameHostID(old_render_process_id, old_render_frame_id)) != 415 RenderFrameHostID(old_render_process_id, old_render_frame_id)) !=
406 visible_main_render_frames_.end()) { 416 visible_main_render_frames_.end()) {
407 WasShownOrHidden(new_render_process_id, new_render_frame_id, true); 417 WasShownOrHidden(new_render_process_id, new_render_frame_id, true);
408 } 418 }
409 } 419 }
410 420
411 } // namespace data_use_measurement 421 } // namespace data_use_measurement
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698