Issue 26142004: Fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26142004: Fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object … (Closed)

Created:
7 years, 2 months ago by Nebojša Ćirić

Modified:
7 years, 2 months ago

Reviewers:
titzer, mnita

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object for the same millisecond timestamp by using UTC methods. Windows: new Date(129193200000); Sun Feb 03 1974 23:00:00 GMT-0800 (Pacific Standard Time) Linux: new Date(129193200000); Mon Feb 04 1974 00:00:00 GMT-0700 (PST) BUG=2919

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	test/intl/date-format/parse-MMMdy.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	test/intl/date-format/parse-mdy.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

Btw. how do I run try bot for "V8 Win32" to check the actual behavior? ...

7 years, 2 months ago (2013-10-10 19:43:22 UTC) #1

Nebojša Ćirić

7 years, 2 months ago (2013-10-10 19:44:37 UTC) #2

On 2013/10/10 19:43:22, Nebojša Ćirić wrote:
> Btw. how do I run try bot for "V8 Win32" to check the actual behavior?
> 
> I've tried "git cl try --bot v8-win23", but no luck.

Original CL got reverted, abandoning this one.

Expand Messages | Collapse Messages