Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 26142003: Enable -fPIE and -pie in tsan build. (Closed)

Created:
7 years, 2 months ago by bungeman-skia
Modified:
7 years, 2 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Enable -fPIE, and -pie in tsan build. We're already -fPIC. R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11701

Patch Set 1 #

Patch Set 2 : Now more correcter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
7 years, 2 months ago (2013-10-10 15:50:25 UTC) #1
mtklein
lgtm
7 years, 2 months ago (2013-10-10 16:04:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/26142003/3001
7 years, 2 months ago (2013-10-10 16:04:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 2 months ago (2013-10-10 16:10:18 UTC) #4
bungeman-skia
7 years, 2 months ago (2013-10-10 17:09:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r11701.

Powered by Google App Engine
This is Rietveld 408576698