Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushController.h

Issue 2614143002: Use a new Supplement constructor for LocalFrame's supplements (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/push_messaging/PushController.h
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushController.h b/third_party/WebKit/Source/modules/push_messaging/PushController.h
index 33748ad1a650aba345b74ac9a3ad6ea83f7e8ec3..2c268770d4e798f3cdcd3a53c0ba93b3af58c632 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushController.h
+++ b/third_party/WebKit/Source/modules/push_messaging/PushController.h
@@ -21,7 +21,8 @@ class PushController final : public GarbageCollected<PushController>,
WTF_MAKE_NONCOPYABLE(PushController);
public:
- static PushController* create(WebPushClient*);
+ PushController(LocalFrame&, WebPushClient*);
+
static const char* supplementName();
static PushController* from(LocalFrame* frame) {
return static_cast<PushController*>(
@@ -32,8 +33,6 @@ class PushController final : public GarbageCollected<PushController>,
DEFINE_INLINE_VIRTUAL_TRACE() { Supplement<LocalFrame>::trace(visitor); }
private:
- explicit PushController(WebPushClient*);
-
WebPushClient* client() const { return m_client; }
WebPushClient* m_client;

Powered by Google App Engine
This is Rietveld 408576698