Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

Issue 2614093002: Combine LayoutObject::previousPaintOffset and paintOffset in paint properties (Closed)
Patch Set: - Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
index e7b0012ddef68ebd4b8514f7d386d75db40c8b96..74eecda3b676d49e0ce6ad2dd77791adb1aebe6d 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
@@ -546,21 +546,14 @@ ObjectPaintInvalidatorWithContext::invalidatePaintIfNeededWithComputedReason(
// for paint offset mutation, but incurs no pixel difference (i.e. bounds
// stay the same) so no rect-based invalidation is issued. See
// crbug.com/508383 and crbug.com/515977.
- if (m_context.forcedSubtreeInvalidationFlags &
- PaintInvalidatorContext::ForcedSubtreeInvalidationChecking) {
- if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
- if (m_context.oldPaintOffset != m_context.newPaintOffset) {
- reason = PaintInvalidationLocationChange;
- break;
- }
- } else {
- // For SPv1, we conservatively assume the object changed paint offset
- // except for non-root SVG whose paint offset is always zero.
- if (!m_object.isSVGChild()) {
- reason = PaintInvalidationLocationChange;
- break;
- }
- }
+ if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
+ (m_context.forcedSubtreeInvalidationFlags &
+ PaintInvalidatorContext::ForcedSubtreeInvalidationChecking) &&
+ !m_object.isSVGChild()) {
+ // For SPv1, we conservatively assume the object changed paint offset
+ // except for non-root SVG whose paint offset is always zero.
+ reason = PaintInvalidationLocationChange;
+ break;
}
if (m_object.isSVG() &&

Powered by Google App Engine
This is Rietveld 408576698