Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: pkg/front_end/test/src/base/processed_options_test.dart

Issue 2614063007: Use URIs rather than paths in front end API. (Closed)
Patch Set: Minor fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:front_end/compiler_options.dart'; 5 import 'package:front_end/compiler_options.dart';
6 import 'package:front_end/memory_file_system.dart'; 6 import 'package:front_end/memory_file_system.dart';
7 import 'package:front_end/src/base/processed_options.dart'; 7 import 'package:front_end/src/base/processed_options.dart';
8 import 'package:path/path.dart' as pathos; 8 import 'package:path/path.dart' as pathos;
9 import 'package:test/test.dart'; 9 import 'package:test/test.dart';
10 import 'package:test_reflective_loader/test_reflective_loader.dart'; 10 import 'package:test_reflective_loader/test_reflective_loader.dart';
11 11
12 main() { 12 main() {
13 defineReflectiveSuite(() { 13 defineReflectiveSuite(() {
14 defineReflectiveTests(ProcessedOptionsTest); 14 defineReflectiveTests(ProcessedOptionsTest);
15 }); 15 });
16 } 16 }
17 17
18 @reflectiveTest 18 @reflectiveTest
19 class ProcessedOptionsTest { 19 class ProcessedOptionsTest {
20 final fileSystem = new MemoryFileSystem(pathos.posix, '/'); 20 final fileSystem = new MemoryFileSystem(pathos.posix, Uri.parse('file:///'));
21 21
22 test_compileSdk_false() { 22 test_compileSdk_false() {
23 for (var value in [false, true]) { 23 for (var value in [false, true]) {
24 var raw = new CompilerOptions()..compileSdk = value; 24 var raw = new CompilerOptions()..compileSdk = value;
25 var processed = new ProcessedOptions(raw); 25 var processed = new ProcessedOptions(raw);
26 expect(processed.compileSdk, value); 26 expect(processed.compileSdk, value);
27 } 27 }
28 } 28 }
29 29
30 test_fileSystem_noBazelRoots() { 30 test_fileSystem_noBazelRoots() {
31 // When no bazel roots are specified, the filesystem should be passed 31 // When no bazel roots are specified, the filesystem should be passed
32 // through unmodified. 32 // through unmodified.
33 var raw = new CompilerOptions()..fileSystem = fileSystem; 33 var raw = new CompilerOptions()..fileSystem = fileSystem;
34 var processed = new ProcessedOptions(raw); 34 var processed = new ProcessedOptions(raw);
35 expect(processed.fileSystem, same(fileSystem)); 35 expect(processed.fileSystem, same(fileSystem));
36 } 36 }
37 37
38 test_getUriResolver_explicitPackagesFile() async { 38 test_getUriResolver_explicitPackagesFile() async {
39 // This .packages file should be ignored. 39 // This .packages file should be ignored.
40 fileSystem.entityForPath('/.packages').writeAsStringSync('foo:bar\n'); 40 fileSystem
41 .entityForUri(Uri.parse('file:///.packages'))
42 .writeAsStringSync('foo:bar\n');
41 // This one should be used. 43 // This one should be used.
42 fileSystem 44 fileSystem
43 .entityForPath('/explicit.packages') 45 .entityForUri(Uri.parse('file:///explicit.packages'))
44 .writeAsStringSync('foo:baz\n'); 46 .writeAsStringSync('foo:baz\n');
45 var raw = new CompilerOptions() 47 var raw = new CompilerOptions()
46 ..fileSystem = fileSystem 48 ..fileSystem = fileSystem
47 ..packagesFilePath = '/explicit.packages'; 49 ..packagesFilePath = Uri.parse('file:///explicit.packages');
48 var processed = new ProcessedOptions(raw); 50 var processed = new ProcessedOptions(raw);
49 var uriResolver = await processed.getUriResolver(); 51 var uriResolver = await processed.getUriResolver();
50 expect(uriResolver.packages, {'foo': Uri.parse('file:///baz/')}); 52 expect(uriResolver.packages, {'foo': Uri.parse('file:///baz/')});
51 expect(uriResolver.pathContext, same(fileSystem.context)); 53 expect(uriResolver.pathContext, same(fileSystem.context));
52 } 54 }
53 55
54 test_getUriResolver_explicitPackagesFile_withBaseLocation() async { 56 test_getUriResolver_explicitPackagesFile_withBaseLocation() async {
55 // This .packages file should be ignored. 57 // This .packages file should be ignored.
56 fileSystem.entityForPath('/.packages').writeAsStringSync('foo:bar\n'); 58 fileSystem
59 .entityForUri(Uri.parse('file:///.packages'))
60 .writeAsStringSync('foo:bar\n');
57 // This one should be used. 61 // This one should be used.
58 fileSystem 62 fileSystem
59 .entityForPath('/base/location/explicit.packages') 63 .entityForUri(Uri.parse('file:///base/location/explicit.packages'))
60 .writeAsStringSync('foo:baz\n'); 64 .writeAsStringSync('foo:baz\n');
61 var raw = new CompilerOptions() 65 var raw = new CompilerOptions()
62 ..fileSystem = fileSystem 66 ..fileSystem = fileSystem
63 ..packagesFilePath = '/base/location/explicit.packages'; 67 ..packagesFilePath = Uri.parse('file:///base/location/explicit.packages');
64 var processed = new ProcessedOptions(raw); 68 var processed = new ProcessedOptions(raw);
65 var uriResolver = await processed.getUriResolver(); 69 var uriResolver = await processed.getUriResolver();
66 expect( 70 expect(
67 uriResolver.packages, {'foo': Uri.parse('file:///base/location/baz/')}); 71 uriResolver.packages, {'foo': Uri.parse('file:///base/location/baz/')});
68 expect(uriResolver.pathContext, same(fileSystem.context)); 72 expect(uriResolver.pathContext, same(fileSystem.context));
69 } 73 }
70 74
71 test_getUriResolver_noPackages() async { 75 test_getUriResolver_noPackages() async {
72 // .packages file should be ignored. 76 // .packages file should be ignored.
73 fileSystem.entityForPath('/.packages').writeAsStringSync('foo:bar\n'); 77 fileSystem
78 .entityForUri(Uri.parse('file:///.packages'))
79 .writeAsStringSync('foo:bar\n');
74 var raw = new CompilerOptions() 80 var raw = new CompilerOptions()
75 ..fileSystem = fileSystem 81 ..fileSystem = fileSystem
76 ..packagesFilePath = ''; 82 ..packagesFilePath = new Uri();
77 var processed = new ProcessedOptions(raw); 83 var processed = new ProcessedOptions(raw);
78 var uriResolver = await processed.getUriResolver(); 84 var uriResolver = await processed.getUriResolver();
79 expect(uriResolver.packages, isEmpty); 85 expect(uriResolver.packages, isEmpty);
80 expect(uriResolver.pathContext, same(fileSystem.context)); 86 expect(uriResolver.pathContext, same(fileSystem.context));
81 } 87 }
82 } 88 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698